webrtc/media/engine/webrtcvideoengine2.cc - Issue 1757683002: Make the audio channel communicate network state changes to the call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 1757683002: Make the audio channel communicate network state changes to the call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Use the presence of send/receive streams to infer which media types are active Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/media/engine/fakewebrtccall.cc ('K') | « webrtc/media/engine/fakewebrtccall.cc ('k') | webrtc/media/engine/webrtcvideoengine2_unittest.cc » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/media/engine/webrtcvideoengine2.cc

diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc

index 0e9866064df142cf7d1529065a818560a674dea3..17bb2c4900b0985d48b6d19683584a951ff763d5 100644

--- a/webrtc/media/engine/webrtcvideoengine2.cc

+++ b/webrtc/media/engine/webrtcvideoengine2.cc

@@ -1360,7 +1360,10 @@ void WebRtcVideoChannel2::OnRtcpReceived(

void WebRtcVideoChannel2::OnReadyToSend(bool ready) {

LOG(LS_VERBOSE) << "OnReadyToSend: " << (ready ? "Ready." : "Not ready.");

- call_->SignalNetworkState(ready ? webrtc::kNetworkUp : webrtc::kNetworkDown);

+ call_->SignalChannelNetworkState(

+ webrtc::MediaType::VIDEO,

the sun 2016/03/07 14:16:43 nit: indent, plus make a single line of the ternar

skvlad 2016/03/07 19:20:56 Done.

+ ready ?

+ webrtc::kNetworkUp : webrtc::kNetworkDown);

}

bool WebRtcVideoChannel2::MuteStream(uint32_t ssrc, bool mute) {