Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: webrtc/call/call.cc

Issue 1757683002: Make the audio channel communicate network state changes to the call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Reenabled the workaround to keep sending audio packets when the pacer is stopped so that audio does… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index 41ac328eab14f44249a20d7ac0dba85a36bb9d1d..5c95d7941f8675828bfee7b962b082a88d1293c3 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -550,6 +550,10 @@ void Call::SetBitrateConfig(
void Call::SignalNetworkState(NetworkState state) {
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
+ // TODO(skvlad): In the unbundled case the network state might be different
pbos-webrtc 2016/03/03 10:18:57 Can you add this now? I think it's scary that audi
stefan-webrtc 2016/03/03 10:23:53 +1, I agree we need to fix this now if we are goin
+ // for the audio and video channels. Currently the last change wins.
+ // Correctly handling this scenario would require tracking the network state
+ // for each media type separately.
network_enabled_ = state == kNetworkUp;
congestion_controller_->SignalNetworkState(state);
{
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698