Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1757683002: Make the audio channel communicate network state changes to the call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing code review issues Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/call/call.cc ('K') | « webrtc/media/engine/webrtcvoiceengine_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 94a87d8864a64b108bfd723aec4e27c16466f953..46e0f9faec8d64b3bd9459dd262c418f7dc22141 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -3220,7 +3220,7 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
WaitForPacketsOrSilence(false, false);
// Sender-side network down.
- sender_call_->SignalNetworkState(kNetworkDown);
+ sender_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkDown);
stefan-webrtc 2016/03/11 08:29:41 Maybe we should add a test which verifies the expe
skvlad 2016/03/11 23:59:08 I've added tests that verify that video streams ar
{
rtc::CritScope lock(&test_crit_);
// After network goes down we shouldn't be encoding more frames.
@@ -3230,7 +3230,7 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
WaitForPacketsOrSilence(true, false);
// Receiver-side network down.
- receiver_call_->SignalNetworkState(kNetworkDown);
+ receiver_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkDown);
WaitForPacketsOrSilence(true, true);
// Network back up again for both.
@@ -3240,8 +3240,8 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
// network.
sender_state_ = kNetworkUp;
}
- sender_call_->SignalNetworkState(kNetworkUp);
- receiver_call_->SignalNetworkState(kNetworkUp);
+ sender_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkUp);
+ receiver_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkUp);
WaitForPacketsOrSilence(false, false);
}
@@ -3378,7 +3378,7 @@ TEST_F(EndToEndTest, NewSendStreamsRespectNetworkDown) {
};
CreateSenderCall(Call::Config());
- sender_call_->SignalNetworkState(kNetworkDown);
+ sender_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkDown);
UnusedTransport transport;
CreateSendConfig(1, 0, &transport);
@@ -3396,7 +3396,7 @@ TEST_F(EndToEndTest, NewSendStreamsRespectNetworkDown) {
TEST_F(EndToEndTest, NewReceiveStreamsRespectNetworkDown) {
CreateCalls(Call::Config(), Call::Config());
- receiver_call_->SignalNetworkState(kNetworkDown);
+ receiver_call_->SignalChannelNetworkState(MediaType::VIDEO, kNetworkDown);
test::DirectTransport sender_transport(sender_call_.get());
sender_transport.SetReceiver(receiver_call_->Receiver());
« webrtc/call/call.cc ('K') | « webrtc/media/engine/webrtcvoiceengine_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698