Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1757683002: Make the audio channel communicate network state changes to the call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing code review issues Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 529d77b14b3a083e4917f758bf8ceb3e345c9836..7144bbcb76c5405bab6ef5031b5bd80500d3100a 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -2422,13 +2422,22 @@ TEST_F(WebRtcVideoChannel2Test, TestSetRecvRtcpReducedSize) {
}
TEST_F(WebRtcVideoChannel2Test, OnReadyToSendSignalsNetworkState) {
- EXPECT_EQ(webrtc::kNetworkUp, fake_call_->GetNetworkState());
+ EXPECT_EQ(webrtc::kNetworkUp,
+ fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
+ EXPECT_EQ(webrtc::kNetworkUp,
+ fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
channel_->OnReadyToSend(false);
- EXPECT_EQ(webrtc::kNetworkDown, fake_call_->GetNetworkState());
+ EXPECT_EQ(webrtc::kNetworkDown,
+ fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
+ EXPECT_EQ(webrtc::kNetworkUp,
+ fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
channel_->OnReadyToSend(true);
- EXPECT_EQ(webrtc::kNetworkUp, fake_call_->GetNetworkState());
+ EXPECT_EQ(webrtc::kNetworkUp,
+ fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
+ EXPECT_EQ(webrtc::kNetworkUp,
+ fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
}
TEST_F(WebRtcVideoChannel2Test, GetStatsReportsSentCodecName) {

Powered by Google App Engine
This is Rietveld 408576698