Enable iOS AppRTCDemo send side BWE.

Enable iOS AppRTCDemo send side BWE.

BUG=

Committed: https://crrev.com/4f735d16ad56cb61f857c7ad813b6d33cd5a9c8a
Cr-Commit-Position: refs/heads/master@{#11865}

[tkchin_webrtc, 2016-03-03 01:11:43]

Description was changed from

==========
Enable iOS AppRTCDemo send side BWE.

BUG=
==========

to

==========
Enable iOS AppRTCDemo send side BWE.

BUG=
==========

[tkchin_webrtc, 2016-03-03 01:11:43]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, hjon@webrtc.org

[Chuck, 2016-03-03 14:38:00]

lgtm

https://codereview.webrtc.org/1757173002/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m (right):

https://codereview.webrtc.org/1757173002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m:29:
RTCInitFieldTrials(RTCFieldTrialOptionsSendSideBwe);
Just a question, the comment says this must be called before any other WebRTC
method, but this call is after RTCPeerConnectioNFactory initializeSSL.

[hjon_webrtc, 2016-03-03 17:26:36]

lgtm

[tkchin_webrtc, 2016-03-03 17:58:41]

https://codereview.webrtc.org/1757173002/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m (right):

https://codereview.webrtc.org/1757173002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m:29:
RTCInitFieldTrials(RTCFieldTrialOptionsSendSideBwe);
On 2016/03/03 14:37:59, Chuck wrote:
> Just a question, the comment says this must be called before any other WebRTC
> method, but this call is after RTCPeerConnectioNFactory initializeSSL.

Yeah, that actually isn't a "WebRTC" method. It just loads/initializes the SSL
library.
The reason it needs to be called before WebRTC stuff is because options for
field trials get loaded on init, so if you call it after init it does nothing.
Essentially as long as you init field trials before you create a
peerconnectionfactory instance you should be fine.
Unless we decide to add a field trial to the SSL init method.
Anyway, moving it up to prevent confusion.

[tkchin_webrtc, 2016-03-03 17:58:46]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-03 17:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from hjon@webrtc.org,
haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1757173002/#ps40001 (title:
"Move field trial init earlier.")

[commit-bot: I haz the power, 2016-03-03 17:58:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757173002/40001

[commit-bot: I haz the power, 2016-03-03 18:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 18:06:01]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3863)

[tkchin_webrtc, 2016-03-03 18:31:02]

tkchin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[tkchin_webrtc, 2016-03-03 18:31:26]

adding kjellander@ for OWNERS

[kjellander_webrtc, 2016-03-03 20:19:06]

kjellander@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[kjellander_webrtc, 2016-03-03 20:19:07]

lgtm but I'm only owner for GYP/GN so you need more.
Adding pthatcher who's in your timezone.

[tkchin_webrtc, 2016-03-03 21:48:51]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-03-03 21:48:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757173002/40001

[commit-bot: I haz the power, 2016-03-03 23:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 23:49:42]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tkchin_webrtc, 2016-03-04 00:56:47]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-03-04 00:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757173002/40001

[commit-bot: I haz the power, 2016-03-04 01:54:32]

Description was changed from

==========
Enable iOS AppRTCDemo send side BWE.

BUG=
==========

to

==========
Enable iOS AppRTCDemo send side BWE.

BUG=
==========

[commit-bot: I haz the power, 2016-03-04 01:54:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-04 01:54:43]

Description was changed from

==========
Enable iOS AppRTCDemo send side BWE.

BUG=
==========

to

==========
Enable iOS AppRTCDemo send side BWE.

BUG=

Committed: https://crrev.com/4f735d16ad56cb61f857c7ad813b6d33cd5a9c8a
Cr-Commit-Position: refs/heads/master@{#11865}
==========

[commit-bot: I haz the power, 2016-03-04 01:54:45]

Patchset 3 (id:??) landed as
https://crrev.com/4f735d16ad56cb61f857c7ad813b6d33cd5a9c8a
Cr-Commit-Position: refs/heads/master@{#11865}