webrtc/system_wrappers/source/rtp_to_ntp.cc - Issue 1756193005: Add histogram stats for AV sync stream offset:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/source/rtp_to_ntp.cc

Issue 1756193005: Add histogram stats for AV sync stream offset: (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: mark constructor explicit Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/system_wrappers/source/rtp_to_ntp.cc

diff --git a/webrtc/system_wrappers/source/rtp_to_ntp.cc b/webrtc/system_wrappers/source/rtp_to_ntp.cc

index 0aceb0625f81a925b96cf55514181adff920778e..706d861b55c82b0457516131c87b2412e87c16ca 100644

--- a/webrtc/system_wrappers/source/rtp_to_ntp.cc

+++ b/webrtc/system_wrappers/source/rtp_to_ntp.cc

@@ -95,7 +95,9 @@ bool UpdateRtcpList(uint32_t ntp_secs,

bool RtpToNtpMs(int64_t rtp_timestamp,

const RtcpList& rtcp,

int64_t* rtp_timestamp_in_ms) {

- assert(rtcp.size() == 2);

+ if (rtcp.size() != 2)

+ return false;

int64_t rtcp_ntp_ms_new = Clock::NtpToMs(rtcp.front().ntp_secs,

rtcp.front().ntp_frac);

int64_t rtcp_ntp_ms_old = Clock::NtpToMs(rtcp.back().ntp_secs,