Remove webrtc/test/webrtc_test_common.gyp

Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/0e73934694c7079507ae9067fb9438bce17971d3
Cr-Commit-Position: refs/heads/master@{#11848}

[kjellander_webrtc, 2016-03-01 07:46:36]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move all sources in webrtc_test_common target into
test.gyp:test_support.
Move all tests in webrtc_test_common_unittests (which wasn't
run on the bots) into test_support_unittests.

Changes made (cuts number of objects down from 1810 to 947):
* Removed dependency on webrtc.gyp:webrtc
* Changed dependency on webrtc/base.gyp:rtc_base -> rtc_base_approved.

BUG=
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move all sources in webrtc_test_common target into
test.gyp:test_support.
Move all tests in webrtc_test_common_unittests (which wasn't
run on the bots) into test_support_unittests.

Changes made: Removed dependency on webrtc.gyp:webrtc

BUG=
==========

[kjellander_webrtc, 2016-03-01 07:53:50]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-03-01 08:03:46]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move all sources in webrtc_test_common target into
test.gyp:test_support.
Move all tests in webrtc_test_common_unittests (which wasn't
run on the bots) into test_support_unittests.

Changes made: Removed dependency on webrtc.gyp:webrtc

BUG=
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move all sources in webrtc_test_common target into
test.gyp:test_support.
Move all tests in webrtc_test_common_unittests (which wasn't
run on the bots) into test_support_unittests.


BUG=
==========

[kjellander_webrtc, 2016-03-02 08:29:39]

Patchset #1 (id:10008) has been deleted

[kjellander_webrtc, 2016-03-02 08:31:28]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move all sources in webrtc_test_common target into
test.gyp:test_support.
Move all tests in webrtc_test_common_unittests (which wasn't
run on the bots) into test_support_unittests.


BUG=
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".
==========

[kjellander_webrtc, 2016-03-02 08:31:29]

kjellander@webrtc.org changed reviewers:
+ pbos@webrtc.org

[kjellander_webrtc, 2016-03-02 08:32:11]

Patchset #1 (id:30001) has been deleted

[kjellander_webrtc, 2016-03-02 08:35:32]

Patchset #1 (id:50001) has been deleted

[kjellander_webrtc, 2016-03-02 09:31:14]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 09:31:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754593002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754593002/70001

[kjellander_webrtc, 2016-03-02 09:31:35]

I wanted to get rid of this unnecessary complexity.

[commit-bot: I haz the power, 2016-03-02 09:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 09:55:07]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3812)

[kjellander_webrtc, 2016-03-02 10:00:19]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2016-03-02 10:00:53]

kjellander@webrtc.org changed reviewers:
- henrika@webrtc.org

[pbos-webrtc, 2016-03-02 12:32:53]

lg, but are there isolate files that need to be renamed or something?

[kjellander_webrtc, 2016-03-02 14:02:31]

On 2016/03/02 12:32:53, pbos-webrtc wrote:
> lg, but are there isolate files that need to be renamed or something?

Right, fixed in PS#2.

[kjellander_webrtc, 2016-03-02 14:03:00]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
==========

[pbos-webrtc, 2016-03-02 14:07:27]

lgtm

[kjellander_webrtc, 2016-03-02 18:10:43]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-03-02 18:10:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754593002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754593002/90001

[commit-bot: I haz the power, 2016-03-02 18:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 18:13:37]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3824)

[kjellander_webrtc, 2016-03-02 18:45:23]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
NOPRESUBMIT=True
==========

[kjellander_webrtc, 2016-03-02 18:45:45]

On 2016/03/02 18:13:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3824)

Adding NOPRESUBMIT=True since pre-existing dependency on rtc_base.

[kjellander_webrtc, 2016-03-02 18:46:08]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-03-02 18:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754593002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754593002/90001

[commit-bot: I haz the power, 2016-03-02 18:46:20]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
NOPRESUBMIT=True
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-03-02 18:46:22]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2016-03-02 18:46:33]

Description was changed from

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename 
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
NOPRESUBMIT=True
==========

to

==========
Remove webrtc/test/webrtc_test_common.gyp

Move the "webrtc_test_common" target to test.gyp and rename
it to "test_common".

Move all tests in "webrtc_test_common_unittests" (which
wasn't run on the bots) into "test_support_unittests".

NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/0e73934694c7079507ae9067fb9438bce17971d3
Cr-Commit-Position: refs/heads/master@{#11848}
==========

[commit-bot: I haz the power, 2016-03-02 18:46:36]

Patchset 2 (id:??) landed as
https://crrev.com/0e73934694c7079507ae9067fb9438bce17971d3
Cr-Commit-Position: refs/heads/master@{#11848}