webrtc/media/engine/webrtcvideoengine2.cc - Issue 1754283002: Make ReconfigureVideoEncoder void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 1754283002: Make ReconfigureVideoEncoder void. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvideoengine2.cc

diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc

index eb6f7dde204e7a8a44c1af8e875fcf7a6051fba1..bd7774c045446db202d93383ec4fc7cb0313961d 100644

--- a/webrtc/media/engine/webrtcvideoengine2.cc

+++ b/webrtc/media/engine/webrtcvideoengine2.cc

@@ -1881,15 +1881,11 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::SetDimensions(

encoder_config.encoder_specific_settings = ConfigureVideoEncoderSettings(

codec_settings.codec);

- bool stream_reconfigured = stream_->ReconfigureVideoEncoder(encoder_config);

+ stream_->ReconfigureVideoEncoder(encoder_config);

encoder_config.encoder_specific_settings = NULL;

pending_encoder_reconfiguration_ = false;

- if (!stream_reconfigured) {

- return;

- }

parameters_.encoder_config = encoder_config;

}