Make ReconfigureVideoEncoder void.

Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder. This is necessary for making
ReconfigureVideoEncoder asynchronous as we don't post any result back.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/905f8e7e9d8ce52bf657797dd46ccf52f16313b5
Cr-Commit-Position: refs/heads/master@{#11847}

[pbos-webrtc, 2016-03-02 15:35:40]

PTAL, reconfiguration shouldn't fail or we're in a weird state. If you prefer we
could log whenever configuring the encoder fails, but it's not really something
we handle in upper code.

[pbos-webrtc, 2016-03-02 15:37:18]

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/vie_encoder.cc
File webrtc/video/vie_encoder.cc (right):

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/vie_encoder.cc#n...
webrtc/video/vie_encoder.cc:222: RTC_CHECK_EQ(VCM_OK, vcm_->RegisterSendCodec(
If you prefer we could not CHECK here but rather fail with a log message. I
think I'd prefer us to see if this is a problem before we silently fail. WDYT?

[pbos-webrtc, 2016-03-02 15:42:19]

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/vie_encoder.cc
File webrtc/video/vie_encoder.cc (right):

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/vie_encoder.cc#n...
webrtc/video/vie_encoder.cc:222: RTC_CHECK_EQ(VCM_OK, vcm_->RegisterSendCodec(
On 2016/03/02 15:37:17, pbos-webrtc wrote:
> If you prefer we could not CHECK here but rather fail with a log message. I
> think I'd prefer us to see if this is a problem before we silently fail. WDYT?

(Note that this CHECK was effectively in place for the initial configuration
(CHECK(ReconfigureVideoEncoder()) in ctor).

[pbos-webrtc, 2016-03-02 15:54:22]

remove CHECK for RegisterSendCodec

[stefan-webrtc, 2016-03-02 15:56:34]

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:359: static const int kEncoderMinBitrate = 30;
Kbps

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/vie_encoder.cc
File webrtc/video/vie_encoder.cc (right):

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/vie_encoder.cc#n...
webrtc/video/vie_encoder.cc:222: RTC_CHECK_EQ(VCM_OK, vcm_->RegisterSendCodec(
On 2016/03/02 15:42:19, pbos-webrtc wrote:
> On 2016/03/02 15:37:17, pbos-webrtc wrote:
> > If you prefer we could not CHECK here but rather fail with a log message. I
> > think I'd prefer us to see if this is a problem before we silently fail.
WDYT?
> 
> (Note that this CHECK was effectively in place for the initial configuration
> (CHECK(ReconfigureVideoEncoder()) in ctor).

DCHECK as discussed.

[stefan-webrtc, 2016-03-02 15:57:09]

lgtm with addressed constant name...

[pbos-webrtc, 2016-03-02 15:57:36]

Kbps

[pbos-webrtc, 2016-03-02 15:57:57]

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1754283002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:359: static const int kEncoderMinBitrate = 30;
On 2016/03/02 15:56:33, stefan-webrtc (holmer) wrote:
> Kbps

Done.

[pbos-webrtc, 2016-03-02 15:58:30]

Description was changed from

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

to

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

[pbos-webrtc, 2016-03-02 15:58:30]

pbos@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[pbos-webrtc, 2016-03-02 15:59:03]

TBR=mflodman@ for webrtc/video_send_stream.h (making ReconfigureVideoEncoder
void).

[pbos-webrtc, 2016-03-02 15:59:34]

Description was changed from

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

to

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder. This is necessary for making 
ReconfigureVideoEncoder asynchronous as we don't post any result back.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

[pbos-webrtc, 2016-03-02 16:00:11]

Description was changed from

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder. This is necessary for making 
ReconfigureVideoEncoder asynchronous as we don't post any result back.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

to

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder. This is necessary for making
ReconfigureVideoEncoder asynchronous as we don't post any result back.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/905f8e7e9d8ce52bf657797dd...
==========

[commit-bot: I haz the power, 2016-03-02 16:00:12]

Description was changed from

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder. This is necessary for making
ReconfigureVideoEncoder asynchronous as we don't post any result back.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/905f8e7e9d8ce52bf657797dd...
==========

to

==========
Make ReconfigureVideoEncoder void.

Also moves and simplifies SetSendCodec from VideoSendStream to mostly
inside ViEEncoder. This is necessary for making
ReconfigureVideoEncoder asynchronous as we don't post any result back.

BUG=webrtc:5494
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/905f8e7e9d8ce52bf657797dd46ccf52f16313b5
Cr-Commit-Position: refs/heads/master@{#11847}
==========

[pbos-webrtc, 2016-03-02 16:00:13]

Committed patchset #3 (id:40001) manually as
905f8e7e9d8ce52bf657797dd46ccf52f16313b5 (presubmit successful).

[commit-bot: I haz the power, 2016-03-02 16:00:13]

Patchset 3 (id:??) landed as
https://crrev.com/905f8e7e9d8ce52bf657797dd46ccf52f16313b5
Cr-Commit-Position: refs/heads/master@{#11847}