webrtc/base/numerics/BUILD.gn - Issue 1753293002: Safe numeric library: base/numerics (copied from Chromium)

Side by Side Diff: webrtc/base/numerics/BUILD.gn

Issue 1753293002: Safe numeric library: base/numerics (copied from Chromium) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comment about chromium_revision Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.	1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

2 #	2 #

3 # Use of this source code is governed by a BSD-style license	3 # Use of this source code is governed by a BSD-style license

4 # that can be found in the LICENSE file in the root of the source	4 # that can be found in the LICENSE file in the root of the source

5 # tree. An additional intellectual property rights grant can be found	5 # tree. An additional intellectual property rights grant can be found

6 # in the file PATENTS. All contributing project authors may	6 # in the file PATENTS. All contributing project authors may

7 # be found in the AUTHORS file in the root of the source tree.	7 # be found in the AUTHORS file in the root of the source tree.

8	8

9 # This file is copied and modified from Chromium (src/BUILD.gn).	9 # GYP version: webrtc/base/numerics/safe_numerics.gyp:safe_numerics

10 group("root") {	10 source_set("safe_numerics") {

11 deps = [	11 sources = [

12 "//webrtc",	12 "safe_conversions.h",

	13 "safe_conversions_impl.h",

	14 "safe_math.h",

	15 "safe_math_impl.h",

13 ]	16 ]
	hbos 2016/03/02 15:46:51 Is this correct (and similar in GYP as a static_li Is this correct (and similar in GYP as a static_library)? What I'm wondering about is this uses some of the stuff from base (checks.h/logging.h), so there is a dependency on base. It compiles as a part of base (is a dependency of it) though so this works fine. However as a stand-alone target we would have to add a dependency on base, which would result in a circular dependency base -> safe_numerics -> base. If this is wrong and a dep on base is needed but not allowed due to circularity, then I suggest we create a .gypi variable for the sources and reference it from the base target as to not have to work on breaking this free from base (not have a stand-alone build target), at least not in this CL. (Or perhaps I mean base_approved when I say base, same concern...) tommi 2016/03/02 16:13:53 Can we make this depend on base and base not depen Show quoted text On 2016/03/02 15:46:51, hbos wrote: > Is this correct (and similar in GYP as a static_library)? > > What I'm wondering about is this uses some of the stuff from base > (checks.h/logging.h), so there is a dependency on base. It compiles as a part of > base (is a dependency of it) though so this works fine. > However as a stand-alone target we would have to add a dependency on base, which > would result in a circular dependency base -> safe_numerics -> base. > > If this is wrong and a dep on base is needed but not allowed due to circularity, > then I suggest we create a .gypi variable for the sources and reference it from > the base target as to not have to work on breaking this free from base (not have > a stand-alone build target), at least not in this CL. > > (Or perhaps I mean base_approved when I say base, same concern...) Can we make this depend on base and base not depend on this? kjellander_webrtc 2016/03/02 18:40:05 Please don't add a new BUILD.gn file, add a new ta Show quoted text On 2016/03/02 16:13:53, tommi-webrtc wrote: > On 2016/03/02 15:46:51, hbos wrote: > > Is this correct (and similar in GYP as a static_library)? Please don't add a new BUILD.gn file, add a new target in webrtc/base/BUILD.gn instead. Show quoted text > > What I'm wondering about is this uses some of the stuff from base > > (checks.h/logging.h), so there is a dependency on base. It compiles as a part > of > > base (is a dependency of it) though so this works fine. > > However as a stand-alone target we would have to add a dependency on base, > which > > would result in a circular dependency base -> safe_numerics -> base. > > > > If this is wrong and a dep on base is needed but not allowed due to > circularity, > > then I suggest we create a .gypi variable for the sources and reference it > from > > the base target as to not have to work on breaking this free from base (not > have > > a stand-alone build target), at least not in this CL. > > > > (Or perhaps I mean base_approved when I say base, same concern...) > > Can we make this depend on base and base not depend on this? We talked about removing the base/logging.h dependency from the source, right? Changing it to webrtc/base/logging.h would also work as long as you don't plan to introduce a dependency from the other base source to base/numerics - or is that something you plan to do? kwiberg-webrtc 2016/03/02 20:14:12 Specifically, can we have base depend on numerics Show quoted text On 2016/03/02 16:13:53, tommi-webrtc wrote: > On 2016/03/02 15:46:51, hbos wrote: > > Is this correct (and similar in GYP as a static_library)? > > > > What I'm wondering about is this uses some of the stuff from base > > (checks.h/logging.h), so there is a dependency on base. It compiles as a part > of > > base (is a dependency of it) though so this works fine. > > However as a stand-alone target we would have to add a dependency on base, > which > > would result in a circular dependency base -> safe_numerics -> base. > > > > If this is wrong and a dep on base is needed but not allowed due to > circularity, > > then I suggest we create a .gypi variable for the sources and reference it > from > > the base target as to not have to work on breaking this free from base (not > have > > a stand-alone build target), at least not in this CL. > > > > (Or perhaps I mean base_approved when I say base, same concern...) > > Can we make this depend on base and base not depend on this? Specifically, can we have base depend on numerics which in turn depends on base_approved? kjellander_webrtc 2016/03/03 10:25:20 I guess that would work since it's not a cycle. Show quoted text On 2016/03/02 20:14:12, kwiberg-webrtc wrote: > On 2016/03/02 16:13:53, tommi-webrtc wrote: > > On 2016/03/02 15:46:51, hbos wrote: > > > Is this correct (and similar in GYP as a static_library)? > > > > > > What I'm wondering about is this uses some of the stuff from base > > > (checks.h/logging.h), so there is a dependency on base. It compiles as a > part > > of > > > base (is a dependency of it) though so this works fine. > > > However as a stand-alone target we would have to add a dependency on base, > > which > > > would result in a circular dependency base -> safe_numerics -> base. > > > > > > If this is wrong and a dep on base is needed but not allowed due to > > circularity, > > > then I suggest we create a .gypi variable for the sources and reference it > > from > > > the base target as to not have to work on breaking this free from base (not > > have > > > a stand-alone build target), at least not in this CL. > > > > > > (Or perhaps I mean base_approved when I say base, same concern...) > > > > Can we make this depend on base and base not depend on this? > > Specifically, can we have base depend on numerics which in turn depends on > base_approved? I guess that would work since it's not a cycle. hbos 2016/03/03 14:17:06 I changed it to webrtc/base/logging.h but it turns Show quoted text On 2016/03/02 18:40:05, kjellander (webrtc) wrote: > On 2016/03/02 16:13:53, tommi-webrtc wrote: > > On 2016/03/02 15:46:51, hbos wrote: > > > Is this correct (and similar in GYP as a static_library)? > > Please don't add a new BUILD.gn file, add a new target in webrtc/base/BUILD.gn > instead. > > > > What I'm wondering about is this uses some of the stuff from base > > > (checks.h/logging.h), so there is a dependency on base. It compiles as a > part > > of > > > base (is a dependency of it) though so this works fine. > > > However as a stand-alone target we would have to add a dependency on base, > > which > > > would result in a circular dependency base -> safe_numerics -> base. > > > > > > If this is wrong and a dep on base is needed but not allowed due to > > circularity, > > > then I suggest we create a .gypi variable for the sources and reference it > > from > > > the base target as to not have to work on breaking this free from base (not > > have > > > a stand-alone build target), at least not in this CL. > > > > > > (Or perhaps I mean base_approved when I say base, same concern...) > > > > Can we make this depend on base and base not depend on this? > > We talked about removing the base/logging.h dependency from the source, right? > Changing it to webrtc/base/logging.h would also work as long as you don't plan > to introduce a dependency from the other base source to base/numerics - or is > that something you plan to do? I changed it to webrtc/base/logging.h but it turns out its not event used. hbos 2016/03/03 14:17:06 Oh, nice. Yes that works. Now we have rtc_base -> Show quoted text On 2016/03/03 10:25:20, kjellander (webrtc) wrote: > On 2016/03/02 20:14:12, kwiberg-webrtc wrote: > > On 2016/03/02 16:13:53, tommi-webrtc wrote: > > > On 2016/03/02 15:46:51, hbos wrote: > > > > Is this correct (and similar in GYP as a static_library)? > > > > > > > > What I'm wondering about is this uses some of the stuff from base > > > > (checks.h/logging.h), so there is a dependency on base. It compiles as a > > part > > > of > > > > base (is a dependency of it) though so this works fine. > > > > However as a stand-alone target we would have to add a dependency on base, > > > which > > > > would result in a circular dependency base -> safe_numerics -> base. > > > > > > > > If this is wrong and a dep on base is needed but not allowed due to > > > circularity, > > > > then I suggest we create a .gypi variable for the sources and reference it > > > from > > > > the base target as to not have to work on breaking this free from base > (not > > > have > > > > a stand-alone build target), at least not in this CL. > > > > > > > > (Or perhaps I mean base_approved when I say base, same concern...) > > > > > > Can we make this depend on base and base not depend on this? > > > > Specifically, can we have base depend on numerics which in turn depends on > > base_approved? > > I guess that would work since it's not a cycle. Oh, nice. Yes that works. Now we have rtc_base -> safe_numerics -> rtc_base_approved (and I verified that this compiles and can link into an executable).
14 }	17 }

OLD	NEW

« no previous file with comments | « webrtc/base/base.gyp ('k') | webrtc/base/numerics/safe_conversions.h » ('j') | webrtc/base/numerics/safe_numerics.gyp » ('J')