Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1751903002: Replace scoped_ptr with unique_ptr in webrtc/video/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/video/ BUG=webrtc:5520 Committed: https://crrev.com/27f982bbcb88cbe5d47ff7e67a2a70063974554d Cr-Commit-Position: refs/heads/master@{#11833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -94 lines) Patch
M webrtc/video/call_stats.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/call_stats_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 17 chunks +22 lines, -22 lines 0 comments Download
M webrtc/video/overuse_frame_detector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/overuse_frame_detector_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/video/payload_router.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/payload_router_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/replay.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video/video_capture_input_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/video_quality_test.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M webrtc/video/vie_channel.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/vie_receiver.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/video/vie_remb.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_remb_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/vie_sync_module.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-01 14:40:55 UTC) #2
pbos-webrtc
lgtm, can you grep for scoped_ptr to see if we reference it in strings/comments as ...
4 years, 9 months ago (2016-03-01 16:14:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751903002/1
4 years, 9 months ago (2016-03-01 17:32:55 UTC) #5
kwiberg-webrtc
On 2016/03/01 16:14:13, pbos-webrtc wrote: > lgtm, can you grep for scoped_ptr to see if ...
4 years, 9 months ago (2016-03-01 17:35:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:52:38 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 19:52:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27f982bbcb88cbe5d47ff7e67a2a70063974554d
Cr-Commit-Position: refs/heads/master@{#11833}

Powered by Google App Engine
This is Rietveld 408576698