Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1751363003: Move all calls after SetEncoder into SetEncoder. (Closed)

Created:
4 years, 9 months ago by pbos-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move all calls after SetEncoder into SetEncoder. Intended to make SetEncoder callable from another thread so that ReconfigureVideoEncoder can post SetEncoder over and return earlier to prevent blocking the calling thread. BUG=webrtc:5494 R=stefan@webrtc.org Committed: https://crrev.com/a03785e924e5b1098a20cdd02fd8001ac4092e8f Cr-Commit-Position: refs/heads/master@{#11856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M webrtc/video/video_send_stream.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M webrtc/video/vie_encoder.h View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 6 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL, woo!
4 years, 9 months ago (2016-03-02 16:13:01 UTC) #1
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-03 10:31:32 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a03785e924e5b1098a20cdd02fd8001ac4092e8f Cr-Commit-Position: refs/heads/master@{#11856}
4 years, 9 months ago (2016-03-03 10:36:30 UTC) #5
pbos-webrtc
4 years, 9 months ago (2016-03-03 10:36:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a03785e924e5b1098a20cdd02fd8001ac4092e8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698