Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1750593002: Rename constants files in webrtc/{media,p2p} (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename constants files in webrtc/{media,p2p} Multiple sources with the same names forces ugly GYP hacks in Chromium's libjingle.gyp. Rename the sources in WebRTC to enable cleaning this up in Chromium. To summarize: webrtc/media/base/constants.{cc,h} -> mediaconstants.{cc,h} webrtc/p2p/base/constants.{cc,h} -> p2pconstants.{cc,h} This CL will require coordinating landing a roll in Chromium. BUG=webrtc:4256 NOTRY=True Committed: https://crrev.com/f475277547c8ff48e4d7dd0007ab1bdb8cbb3b4a Cr-Commit-Position: refs/heads/master@{#11842}

Patch Set 1 #

Patch Set 2 : Removed cricket naming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -447 lines) Patch
M webrtc/api/jsepsessiondescription_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsdp.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/codec.h View 1 1 chunk +1 line, -1 line 0 comments Download
D webrtc/media/base/constants.h View 1 chunk +0 lines, -167 lines 0 comments Download
D webrtc/media/base/constants.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/media/base/mediaconstants.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/media/base/mediaconstants.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/rtpdataengine.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/rtpdataengine.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/rtpdataengine_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videoadapter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/media.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/sctp/sctpdataengine.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/sctp/sctpdataengine_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/candidate.h View 1 1 chunk +1 line, -1 line 0 comments Download
D webrtc/p2p/base/constants.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/p2p/base/constants.cc View 1 chunk +0 lines, -50 lines 0 comments Download
A + webrtc/p2p/base/p2pconstants.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/p2p/base/p2pconstants.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transport.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportdescription.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportdescription.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportinfo.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/p2p.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/mediasession.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/mediasession.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
kjellander_webrtc
4 years, 9 months ago (2016-02-29 15:13:57 UTC) #3
perkj_webrtc
I think the ns cricket is beeing deprecated although at a slow pace. Suggest media_constants ...
4 years, 9 months ago (2016-03-01 07:59:37 UTC) #4
kjellander_webrtc
On 2016/03/01 07:59:37, perkj_webrtc wrote: > I think the ns cricket is beeing deprecated although ...
4 years, 9 months ago (2016-03-01 08:57:52 UTC) #6
perkj_webrtc
On 2016/03/01 08:57:52, kjellander (webrtc) wrote: > On 2016/03/01 07:59:37, perkj_webrtc wrote: > > I ...
4 years, 9 months ago (2016-03-01 13:51:39 UTC) #7
kjellander_webrtc
On 2016/03/01 13:51:39, perkj_webrtc wrote: > On 2016/03/01 08:57:52, kjellander (webrtc) wrote: > > On ...
4 years, 9 months ago (2016-03-01 15:29:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750593002/20001
4 years, 9 months ago (2016-03-02 13:40:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 13:42:33 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 13:42:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f475277547c8ff48e4d7dd0007ab1bdb8cbb3b4a
Cr-Commit-Position: refs/heads/master@{#11842}

Powered by Google App Engine
This is Rietveld 408576698