webrtc/modules/audio_coding/acm2/acm_receiver.h - Issue 1750353002: Change NetEq::GetAudio to use AudioFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/acm_receiver.h

Issue 1750353002: Change NetEq::GetAudio to use AudioFrame (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Taking care of review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/acm2/acm_receiver.h

diff --git a/webrtc/modules/audio_coding/acm2/acm_receiver.h b/webrtc/modules/audio_coding/acm2/acm_receiver.h

index f5ceb61fbdccdb41d27d804045160cd8787bad1a..8d64a3c1ea2f171a6c40dcfcc275f83c249e4df7 100644

--- a/webrtc/modules/audio_coding/acm2/acm_receiver.h

+++ b/webrtc/modules/audio_coding/acm2/acm_receiver.h

@@ -286,9 +286,6 @@ class AcmReceiver {

const Decoder* last_audio_decoder_ GUARDED_BY(crit_sect_);

AudioFrame::VADActivity previous_audio_activity_ GUARDED_BY(crit_sect_);

ACMResampler resampler_ GUARDED_BY(crit_sect_);

- // Used in GetAudio, declared as member to avoid allocating every 10ms.

- // TODO(henrik.lundin) Stack-allocate in GetAudio instead?

- std::unique_ptr<int16_t[]> audio_buffer_ GUARDED_BY(crit_sect_);

std::unique_ptr<int16_t[]> last_audio_buffer_ GUARDED_BY(crit_sect_);

CallStatistics call_stats_ GUARDED_BY(crit_sect_);

NetEq* neteq_;