Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1749693002: rtc::Buffer: Use RTC_DCHECK instead of assert (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

rtc::Buffer: Use RTC_DCHECK instead of assert Committed: https://crrev.com/e3d99221c416ea2f5a1675667be26c14327afc75 Cr-Commit-Position: refs/heads/master@{#11826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M webrtc/base/buffer.h View 9 chunks +14 lines, -15 lines 0 comments Download
M webrtc/base/buffer.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-01 09:17:29 UTC) #2
tommi
lgtm
4 years, 9 months ago (2016-03-01 09:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749693002/1
4 years, 9 months ago (2016-03-01 09:27:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 09:57:41 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 09:57:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3d99221c416ea2f5a1675667be26c14327afc75
Cr-Commit-Position: refs/heads/master@{#11826}

Powered by Google App Engine
This is Rietveld 408576698