DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

This is a preparation CL. The expires param will be used in
a follow-up CL. Initially it will only be used by the
chromium implementation. Then we will either update the
webrtc implementation (DtlsIdentityStoreImpl) to use it or
we will remove that store completely as part of clean-up
work.

There are currently two versions of RequestIdentity, one
that takes KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently
implements that. This is the version that can be removed in
a follow-up CL.

BUG=webrtc:5092, chromium:544902
Committed: https://crrev.com/25359e0cc28f964354a5bac4ad63eb5b22576aa8
Cr-Commit-Position: refs/heads/master@{#11846}

[hbos, 2016-03-01 16:44:42]

hbos@webrtc.org changed reviewers:
+ torbjorng@webrtc.org

[hbos, 2016-03-01 16:44:43]

Please take a look torbjorng.

Cleanup of RequestIdentity might seem silly to do when we plan to remove it
soon, but without this cleanup we'll en up with three versions of
RequestIdentity after my follow-up chromium CL for
RTCPeerConnection.generateCertificate.

If this and that CL lands we can simply remove the second version of
RequestIdentity instead.

[hbos, 2016-03-01 16:48:58]

hbos@webrtc.org changed reviewers:
+ perkj@webrtc.org

[hbos, 2016-03-01 16:48:58]

And please take a look perkj.

Remember the two versions of RequestIdentity that gave you compilation problems
a while back? After this and a chromium CL we can remove so that there is only
one version, yay.

[hbos_google, 2016-03-02 09:15:07]

Patchset #2 (id:20001) has been deleted

[hbos, 2016-03-02 12:20:10]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

As to not break chromium there are still two versions of
RequestIdentity, but after a follow-up CL in chromium we can remove the
other version of RequestIdentity.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

As to not break chromium there are still two versions of
RequestIdentity, but after a follow-up CL in chromium we can remove the
other version of RequestIdentity.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium. This is the one
that can be removed in a follow-up CL.

BUG=webrtc:5092, chromium:544902
==========

[hbos, 2016-03-02 12:52:18]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

As to not break chromium there are still two versions of
RequestIdentity, but after a follow-up CL in chromium we can remove the
other version of RequestIdentity.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium. This is the one
that can be removed in a follow-up CL.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

There are currently two versions of RequestIdentity, one that takes
KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently implements
that. This is the version that can be removed in a follow-up CL.

This is a preparation CL. The expires param will be used in a follow-up
CL. Initially it will only be used by the chromium implementation. Then
we will either update the webrtc implementation (DtlsIdentityStoreImpl)
to use it or we will remove that store completely as part of clean-up
work.

BUG=webrtc:5092, chromium:544902
==========

[torbjorng (webrtc), 2016-03-02 13:15:55]

lgtm

You might want to start the description with that much of this are intermediate
interfaces while changing Chrome.

https://codereview.webrtc.org/1749193002/diff/1/webrtc/api/dtlsidentitystore.h
File webrtc/api/dtlsidentitystore.h (right):

https://codereview.webrtc.org/1749193002/diff/1/webrtc/api/dtlsidentitystore....
webrtc/api/dtlsidentitystore.h:63: // above version exists because it is
currently implemented in chromium. The
Nit: "Above" version => "1st version below".
     "Below" version => "2nd version below".

[perkj_webrtc, 2016-03-02 13:27:40]

lgtm

[hbos, 2016-03-02 14:19:00]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

There are currently two versions of RequestIdentity, one that takes
KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently implements
that. This is the version that can be removed in a follow-up CL.

This is a preparation CL. The expires param will be used in a follow-up
CL. Initially it will only be used by the chromium implementation. Then
we will either update the webrtc implementation (DtlsIdentityStoreImpl)
to use it or we will remove that store completely as part of clean-up
work.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

This is a preparation CL. The expires param will be used in
a follow-up CL. Initially it will only be used by the
chromium implementation. Then we will either update the
webrtc implementation (DtlsIdentityStoreImpl) to use it or
we will remove that store completely as part of clean-up
work.

There are currently two versions of RequestIdentity, one
that takes KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently
implements that. This is the version that can be removed in
a follow-up CL.

BUG=webrtc:5092, chromium:544902
==========

[hbos, 2016-03-02 14:22:18]

https://codereview.webrtc.org/1749193002/diff/1/webrtc/api/dtlsidentitystore.h
File webrtc/api/dtlsidentitystore.h (right):

https://codereview.webrtc.org/1749193002/diff/1/webrtc/api/dtlsidentitystore....
webrtc/api/dtlsidentitystore.h:63: // above version exists because it is
currently implemented in chromium. The
On 2016/03/02 13:15:55, torbjorng (webrtc) wrote:
> Nit: "Above" version => "1st version below".
>      "Below" version => "2nd version below".

Done.

[hbos, 2016-03-02 14:22:22]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-03-02 14:22:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
torbjorng@webrtc.org, perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1749193002/#ps40001 (title:
"Addressed nit")

[commit-bot: I haz the power, 2016-03-02 14:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749193002/40001

[commit-bot: I haz the power, 2016-03-02 15:55:56]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

This is a preparation CL. The expires param will be used in
a follow-up CL. Initially it will only be used by the
chromium implementation. Then we will either update the
webrtc implementation (DtlsIdentityStoreImpl) to use it or
we will remove that store completely as part of clean-up
work.

There are currently two versions of RequestIdentity, one
that takes KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently
implements that. This is the version that can be removed in
a follow-up CL.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

This is a preparation CL. The expires param will be used in
a follow-up CL. Initially it will only be used by the
chromium implementation. Then we will either update the
webrtc implementation (DtlsIdentityStoreImpl) to use it or
we will remove that store completely as part of clean-up
work.

There are currently two versions of RequestIdentity, one
that takes KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently
implements that. This is the version that can be removed in
a follow-up CL.

BUG=webrtc:5092, chromium:544902
==========

[commit-bot: I haz the power, 2016-03-02 15:55:57]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-02 15:56:02]

Description was changed from

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

This is a preparation CL. The expires param will be used in
a follow-up CL. Initially it will only be used by the
chromium implementation. Then we will either update the
webrtc implementation (DtlsIdentityStoreImpl) to use it or
we will remove that store completely as part of clean-up
work.

There are currently two versions of RequestIdentity, one
that takes KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently
implements that. This is the version that can be removed in
a follow-up CL.

BUG=webrtc:5092, chromium:544902
==========

to

==========
DtlsIdentityStoreInterface::RequestIdentity gets optional expires param.

This is a preparation CL. The expires param will be used in
a follow-up CL. Initially it will only be used by the
chromium implementation. Then we will either update the
webrtc implementation (DtlsIdentityStoreImpl) to use it or
we will remove that store completely as part of clean-up
work.

There are currently two versions of RequestIdentity, one
that takes KeyType and one that takes KeyParams.

The KeyType version is removed in favor of the new
KeyParams + expires version. The KeyParams version without
expires is kept as to not break chromium which currently
implements that. This is the version that can be removed in
a follow-up CL.

BUG=webrtc:5092, chromium:544902

Committed: https://crrev.com/25359e0cc28f964354a5bac4ad63eb5b22576aa8
Cr-Commit-Position: refs/heads/master@{#11846}
==========

[commit-bot: I haz the power, 2016-03-02 15:56:04]

Patchset 2 (id:??) landed as
https://crrev.com/25359e0cc28f964354a5bac4ad63eb5b22576aa8
Cr-Commit-Position: refs/heads/master@{#11846}