Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
index a3de360cf6a4a399eb82bbfa5353bf2e83061d2a..60e5776260e73fbf1464849282fd5d8003bc0419 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
@@ -91,7 +91,7 @@ RTCPSender::FeedbackState::FeedbackState()
class PacketContainer : public rtcp::CompoundPacket,
public rtcp::RtcpPacket::PacketReadyCallback {
public:
- PacketContainer(Transport* transport, RtcEventLog* event_log)
+ PacketContainer(Transport* transport, RtcEventLogProxy* event_log)
: transport_(transport), event_log_(event_log), bytes_sent_(0) {}
virtual ~PacketContainer() {
for (RtcpPacket* packet : appended_packets_)
@@ -115,7 +115,7 @@ class PacketContainer : public rtcp::CompoundPacket,
private:
Transport* transport_;
- RtcEventLog* const event_log_;
+ RtcEventLogProxy* const event_log_;
size_t bytes_sent_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(PacketContainer);
@@ -158,7 +158,7 @@ RTCPSender::RTCPSender(
Clock* clock,
ReceiveStatistics* receive_statistics,
RtcpPacketTypeCounterObserver* packet_type_counter_observer,
- RtcEventLog* event_log,
+ RtcEventLogProxy* event_log,
Transport* outgoing_transport)
: audio_(audio),
clock_(clock),
@@ -1026,7 +1026,7 @@ bool RTCPSender::AllVolatileFlagsConsumed() const {
bool RTCPSender::SendFeedbackPacket(const rtcp::TransportFeedback& packet) {
class Sender : public rtcp::RtcpPacket::PacketReadyCallback {
public:
- Sender(Transport* transport, RtcEventLog* event_log)
+ Sender(Transport* transport, RtcEventLogProxy* event_log)
: transport_(transport), event_log_(event_log), send_failure_(false) {}
void OnPacketReady(uint8_t* data, size_t length) override {
@@ -1041,7 +1041,7 @@ bool RTCPSender::SendFeedbackPacket(const rtcp::TransportFeedback& packet) {
}
Transport* const transport_;
- RtcEventLog* const event_log_;
+ RtcEventLogProxy* const event_log_;
bool send_failure_;
// TODO(terelius): We would like to
// RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(Sender);
@@ -1052,5 +1052,4 @@ bool RTCPSender::SendFeedbackPacket(const rtcp::TransportFeedback& packet) {
return packet.BuildExternalBuffer(buffer, IP_PACKET_SIZE, &sender) &&
!sender.send_failure_;
}
-
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698