webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('K') | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | webrtc/modules/congestion_controller/congestion_controller.cc » ('j') | webrtc/modules/rtp_rtcp/include/rtp_rtcp.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

index a6fda5be35d9b8cd3fc7adc8e8c8b85528bc45cf..1bf8e86a1b43fe99a282ef5ee2f2775702b20fe2 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

@@ -17,7 +17,7 @@

namespace webrtc {

void TestProbing(bool use_delay_based) {

- SendSideBandwidthEstimation bwe;

+ SendSideBandwidthEstimation bwe(nullptr);

bwe.SetMinMaxBitrate(100000, 1500000);

bwe.SetSendBitrate(200000);

@@ -62,7 +62,7 @@ TEST(SendSideBweTest, InitialDelayBasedBweWithProbing) {

}

TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) {

- SendSideBandwidthEstimation bwe;

+ SendSideBandwidthEstimation bwe(nullptr);

static const int kMinBitrateBps = 100000;

static const int kInitialBitrateBps = 1000000;

bwe.SetMinMaxBitrate(kMinBitrateBps, 1500000);