webrtc/call/rtc_event_log.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/rtc_event_log.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/call/rtc_event_log.h

diff --git a/webrtc/call/rtc_event_log.h b/webrtc/call/rtc_event_log.h

index 027f6867c6fea91d465c4e31718f6cc8b46d9d83..b287ee36f72128852d6670fe1d38ad0b37f8cb17 100644

--- a/webrtc/call/rtc_event_log.h

+++ b/webrtc/call/rtc_event_log.h

@@ -50,8 +50,10 @@ class RtcEventLog {

// Starts logging until either the 10 minute timer runs out or the StopLogging

// function is called. The RtcEventLog takes ownership of the supplied

- // rtc::PlatformFile.

- virtual bool StartLogging(rtc::PlatformFile log_file) = 0;

+ // rtc::PlatformFile. The max_size_bytes argument is ignored, it is added here

+ // for future use.

+ virtual bool StartLogging(rtc::PlatformFile log_file,

+ int64_t max_size_bytes) = 0;

virtual void StopLogging() = 0;

« no previous file with comments | « webrtc/call/mock/mock_rtc_event_log.h ('k') | webrtc/call/rtc_event_log.cc » ('j') | webrtc/call/rtc_event_log.cc » ('J')