webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Another rebase and accompanying changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/include/bitrate_controller.h ('k') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

index 402d22a6bf4378a18a567d658412461100d6bccf..c97714f7e863ae0c5cc941dca38e723408e6d4b3 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

@@ -26,7 +26,8 @@ class RtcEventLog;

class SendSideBandwidthEstimation {

public:

- SendSideBandwidthEstimation();

+ SendSideBandwidthEstimation() = delete;

+ explicit SendSideBandwidthEstimation(RtcEventLog* event_log);

virtual ~SendSideBandwidthEstimation();

void CurrentEstimate(int* bitrate, uint8_t* loss, int64_t* rtt) const;

@@ -53,8 +54,6 @@ class SendSideBandwidthEstimation {

void SetMinMaxBitrate(int min_bitrate, int max_bitrate);

int GetMinBitrate() const;

- void SetEventLog(RtcEventLog* event_log);

private:

enum UmaState { kNoUpdate, kFirstDone, kDone };