Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Another rebase and accompanying changes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 2ddf67dd3a6d76d70236b8562cf2d5d8208bbd70..d329270ce5af736f709a4167abab364c2871a490 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -28,7 +28,6 @@
#include "webrtc/base/stringencode.h"
#include "webrtc/base/stringutils.h"
#include "webrtc/base/trace_event.h"
-#include "webrtc/call/rtc_event_log.h"
#include "webrtc/common.h"
#include "webrtc/media/base/audiosource.h"
#include "webrtc/media/base/mediaconstants.h"
@@ -1040,27 +1039,6 @@ void WebRtcVoiceEngine::StopAecDump() {
}
}
-bool WebRtcVoiceEngine::StartRtcEventLog(rtc::PlatformFile file,
- int64_t max_size_bytes) {
- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
- webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog();
- if (event_log) {
- return event_log->StartLogging(file, max_size_bytes);
- }
- LOG_RTCERR0(StartRtcEventLog);
- return false;
-}
-
-void WebRtcVoiceEngine::StopRtcEventLog() {
- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
- webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog();
- if (event_log) {
- event_log->StopLogging();
- return;
- }
- LOG_RTCERR0(StopRtcEventLog);
-}
-
int WebRtcVoiceEngine::CreateVoEChannel() {
RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
return voe_wrapper_->base()->CreateChannel(voe_config_);
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | webrtc/modules/bitrate_controller/bitrate_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698