Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: webrtc/media/base/mediaengine.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Another rebase and accompanying changes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/rtc_event_log.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/mediaengine.h
diff --git a/webrtc/media/base/mediaengine.h b/webrtc/media/base/mediaengine.h
index 0e2b7efa86e2dd8e1769e384dfd27d50a7cc3652..dd1f5272a067dc21599eef469e71364ef9035ac7 100644
--- a/webrtc/media/base/mediaengine.h
+++ b/webrtc/media/base/mediaengine.h
@@ -88,15 +88,6 @@ class MediaEngineInterface {
// Stops recording AEC dump.
virtual void StopAecDump() = 0;
-
- // Starts RtcEventLog using existing file. A maximum file size in bytes can be
- // specified. Logging is stopped just before the size limit is exceeded.
- // If max_size_bytes is set to a value <= 0, no limit will be used.
- virtual bool StartRtcEventLog(rtc::PlatformFile file,
- int64_t max_size_bytes) = 0;
-
- // Stops recording an RtcEventLog.
- virtual void StopRtcEventLog() = 0;
};
@@ -175,13 +166,6 @@ class CompositeMediaEngine : public MediaEngineInterface {
voice_.StopAecDump();
}
- virtual bool StartRtcEventLog(rtc::PlatformFile file,
- int64_t max_size_bytes) {
- return voice_.StartRtcEventLog(file, max_size_bytes);
- }
-
- virtual void StopRtcEventLog() { voice_.StopRtcEventLog(); }
-
protected:
VOICE voice_;
VIDEO video_;
« no previous file with comments | « webrtc/call/rtc_event_log.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698