webrtc/voice_engine/include/voe_codec.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/include/voe_codec.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/voice_engine/channel.cc ('K') | « webrtc/voice_engine/channel_proxy.cc ('k') | webrtc/voice_engine/test/auto_test/standard/codec_test.cc » ('j') | webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/voice_engine/include/voe_codec.h

diff --git a/webrtc/voice_engine/include/voe_codec.h b/webrtc/voice_engine/include/voe_codec.h

index 6c4fb38a2faf4fa18093ba0bbca2cd85853d3c63..5d94ac27365a91fa3df47901f28ad66422ab7b4f 100644

--- a/webrtc/voice_engine/include/voe_codec.h

+++ b/webrtc/voice_engine/include/voe_codec.h

@@ -35,7 +35,6 @@

namespace webrtc {

-class RtcEventLog;

class VoiceEngine;

class WEBRTC_DLLEXPORT VoECodec {

@@ -132,10 +131,6 @@ class WEBRTC_DLLEXPORT VoECodec {

// success, and -1 if failed.

virtual int SetOpusDtx(int channel, bool enable_dtx) = 0;

- // Get a pointer to the event logging object associated with this Voice

the sun 2016/03/03 09:25:13 Remember that here you're changing an interface th

ivoc 2016/03/10 13:15:36 It was introduced in Sept 2015, and is not current

- // Engine. This pointer will remain valid until VoiceEngine is destroyed.

- virtual RtcEventLog* GetEventLog() = 0;

protected:

VoECodec() {}

virtual ~VoECodec() {}