webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtcp_sender.h ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h » ('j') | webrtc/modules/rtp_rtcp/source/rtp_sender.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

index f440da489d817351f9c3b334a75a7b2ee9c5325b..ade8e932122f38cbaf6790e3d47f12a351c8d910 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

@@ -238,7 +238,7 @@ class RtcpSenderTest : public ::testing::Test {

rtp_rtcp_impl_.reset(new ModuleRtpRtcpImpl(configuration));

rtcp_sender_.reset(new RTCPSender(false, &clock_, receive_statistics_.get(),

- nullptr, nullptr, &test_transport_));

+ nullptr, &test_transport_));

rtcp_sender_->SetSSRC(kSenderSsrc);

rtcp_sender_->SetRemoteSSRC(kRemoteSsrc);

}

@@ -646,7 +646,7 @@ TEST_F(RtcpSenderTest, TestNoXrRrtrSentIfNotEnabled) {

TEST_F(RtcpSenderTest, TestRegisterRtcpPacketTypeObserver) {

RtcpPacketTypeCounterObserverImpl observer;

rtcp_sender_.reset(new RTCPSender(false, &clock_, receive_statistics_.get(),

- &observer, nullptr, &test_transport_));

+ &observer, &test_transport_));

rtcp_sender_->SetRemoteSSRC(kRemoteSsrc);

rtcp_sender_->SetRTCPStatus(RtcpMode::kReducedSize);

EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpPli));

@@ -766,7 +766,7 @@ TEST_F(RtcpSenderTest, ByeMustBeLast) {

// Re-configure rtcp_sender_ with mock_transport_

rtcp_sender_.reset(new RTCPSender(false, &clock_, receive_statistics_.get(),

- nullptr, nullptr, &mock_transport));

+ nullptr, &mock_transport));

rtcp_sender_->SetSSRC(kSenderSsrc);

rtcp_sender_->SetRemoteSSRC(kRemoteSsrc);