Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h
index 977c1ff43a04579abd227c6c914513999f663dd8..4e4f035da9bc79c9c11b590b252e7f3bab44d252 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h
@@ -79,7 +79,6 @@ class RTCPSender {
Clock* clock,
ReceiveStatistics* receive_statistics,
RtcpPacketTypeCounterObserver* packet_type_counter_observer,
- RtcEventLog* event_log,
Transport* outgoing_transport);
virtual ~RTCPSender();
@@ -149,6 +148,8 @@ class RTCPSender {
void SetTargetBitrate(unsigned int target_bitrate);
bool SendFeedbackPacket(const rtcp::TransportFeedback& packet);
+ void SetRtcEventLog(RtcEventLog* event_log);
+
private:
class RtcpContext;
@@ -202,7 +203,8 @@ class RTCPSender {
Random random_ GUARDED_BY(critical_section_rtcp_sender_);
RtcpMode method_ GUARDED_BY(critical_section_rtcp_sender_);
- RtcEventLog* const event_log_;
+ rtc::scoped_ptr<CriticalSectionWrapper> event_log_crit_;
+ RtcEventLog* event_log_ GUARDED_BY(event_log_crit_);
the sun 2016/03/03 09:25:13 Can you use critical_section_rtcp_sender_ instead?
stefan-webrtc 2016/03/03 10:08:25 Or set it in the constructor and make it const?
ivoc 2016/03/10 13:15:36 This is changed into a pointer to the proxy object
Transport* const transport_;
rtc::scoped_ptr<CriticalSectionWrapper> critical_section_rtcp_sender_;

Powered by Google App Engine
This is Rietveld 408576698