Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index e0ace4c775d76c9df39d0d9a69954cb9c8b50df2..22d045ea182f753417d36ca1e036f24c8ba1b513 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -75,7 +75,6 @@ class RtpRtcp : public Module {
BitrateStatisticsObserver* send_bitrate_observer;
FrameCountObserver* send_frame_count_observer;
SendSideDelayObserver* send_side_delay_observer;
- RtcEventLog* event_log;
stefan-webrtc 2016/03/03 10:08:25 Why do we have to make this change? If it really i
the sun 2016/03/03 10:17:15 That's a good idea! Put the proxy among the others
ivoc 2016/03/10 13:15:36 The reason for this change is that we no longer ha
RTC_DISALLOW_COPY_AND_ASSIGN(Configuration);
};
@@ -649,6 +648,11 @@ class RtpRtcp : public Module {
* return -1 on failure else 0
*/
virtual int32_t RequestKeyFrame() = 0;
+
+ /*
+ * Set the RtcEventLog object.
+ */
+ virtual void SetRtcEventLog(webrtc::RtcEventLog* event_log) = 0;
};
} // namespace webrtc
#endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_

Powered by Google App Engine
This is Rietveld 408576698