webrtc/api/peerconnectionfactory.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnectionfactory.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/peerconnectionfactory.h

diff --git a/webrtc/api/peerconnectionfactory.h b/webrtc/api/peerconnectionfactory.h

index 3ba4124096e4300f79593460f70d67b8af48eb03..c16e3822725a389e12b7d25357b6de8c5b4001e8 100644

--- a/webrtc/api/peerconnectionfactory.h

+++ b/webrtc/api/peerconnectionfactory.h

@@ -67,8 +67,8 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {

bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) override;

void StopAecDump() override;

- bool StartRtcEventLog(rtc::PlatformFile file) override;

- void StopRtcEventLog() override;

+ bool StartRtcEventLog(rtc::PlatformFile file) override { return false; }

the sun 2016/03/03 09:25:12 Add a TODO that these should be removed

ivoc 2016/03/10 13:15:36 Done.

+ void StopRtcEventLog() override {}

virtual webrtc::MediaControllerInterface* CreateMediaController(

const cricket::MediaConfig& config) const;

« webrtc/api/peerconnection.cc ('K') | « webrtc/api/peerconnection.cc ('k') | webrtc/api/peerconnectionfactory.cc » ('j') | webrtc/api/peerconnectionfactory.cc » ('J')