Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/api/peerconnection.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnection.h
diff --git a/webrtc/api/peerconnection.h b/webrtc/api/peerconnection.h
index a63dd4342358fc96b21a38fe3f67237ed7d98545..674c81b64b7117bdff980353089d375c04e7807f 100644
--- a/webrtc/api/peerconnection.h
+++ b/webrtc/api/peerconnection.h
@@ -122,6 +122,9 @@ class PeerConnection : public PeerConnectionInterface,
void RegisterUMAObserver(UMAObserver* observer) override;
+ bool StartRtcEventLog(rtc::PlatformFile file) override;
+ void StopRtcEventLog() override;
+
void Close() override;
// Virtual for unit tests.
@@ -329,6 +332,13 @@ class PeerConnection : public PeerConnectionInterface,
// or nullptr if not found.
DataChannel* FindDataChannelBySid(int sid) const;
+ // Starts recording an Rtc EventLog using the supplied platform file.
terelius 2016/03/10 10:42:32 RtcEventLog as one word maybe?
+ // This function should only be called from the worker thread.
+ bool StartRtcEventLog_w(rtc::PlatformFile file);
+ // Starts recording an Rtc EventLog using the supplied platform file.
+ // This function should only be called from the worker thread.
+ void StopRtcEventLog_w();
+
// Storing the factory as a scoped reference pointer ensures that the memory
// in the PeerConnectionFactoryImpl remains available as long as the
// PeerConnection is running. It is passed to PeerConnection as a raw pointer.

Powered by Google App Engine
This is Rietveld 408576698