Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: webrtc/api/java/src/org/webrtc/PeerConnection.java

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Updated RTP/RTCP module to use setter methods instead of passing the event log pointer in the const… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/java/src/org/webrtc/PeerConnection.java
diff --git a/webrtc/api/java/src/org/webrtc/PeerConnection.java b/webrtc/api/java/src/org/webrtc/PeerConnection.java
index 3c9fa0ee21f248a87fc4f3e0ac860be6e733e8fc..44b82696a24773e66ed077f015624af1f7332607 100644
--- a/webrtc/api/java/src/org/webrtc/PeerConnection.java
+++ b/webrtc/api/java/src/org/webrtc/PeerConnection.java
@@ -237,6 +237,19 @@ public class PeerConnection {
return nativeGetStats(observer, (track == null) ? 0 : track.nativeTrack);
}
+ // Starts recording an RTC event log. Ownership of the file is transfered to
+ // the native code. If an RTC event log is already being recorded, it will be
+ // stopped and a new one will start using the provided file.
+ public boolean startRtcEventLog(int file_descriptor) {
the sun 2016/03/03 09:25:12 as discussed offline, add the max file size here t
ivoc 2016/03/10 13:15:35 Done.
+ return nativeStartRtcEventLog(nativePeerConnection, file_descriptor);
+ }
+
+ // Stops recording an RTC event log. If no RTC event log is currently being
+ // recorded, this call will have no effect.
+ public void StopRtcEventLog() {
the sun 2016/03/03 09:25:12 lower case 's' in 'stop'
ivoc 2016/03/10 13:15:35 Done.
+ nativeStopRtcEventLog(nativePeerConnection);
+ }
+
// TODO(fischman): add support for DTMF-related methods once that API
// stabilizes.
public native SignalingState signalingState();
@@ -285,4 +298,10 @@ public class PeerConnection {
private native List<RtpSender> nativeGetSenders();
private native List<RtpReceiver> nativeGetReceivers();
+
+ private static native boolean nativeStartRtcEventLog(
+ long nativePeerConnection, int file_descriptor);
+
+ private static native void nativeStopRtcEventLog(long nativePeerConnection);
+
}

Powered by Google App Engine
This is Rietveld 408576698