Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: More fixes for bots. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 6fe3d86fd98f086fe0622711c7769573d5276a1b..0a84ff797e3379703d63bccbf25a3c107c37a4fe 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -27,7 +27,6 @@
#include "webrtc/base/stringencode.h"
#include "webrtc/base/stringutils.h"
#include "webrtc/base/trace_event.h"
-#include "webrtc/call/rtc_event_log.h"
#include "webrtc/common.h"
#include "webrtc/media/base/audioframe.h"
#include "webrtc/media/base/audiosource.h"
@@ -1112,26 +1111,6 @@ void WebRtcVoiceEngine::StopAecDump() {
}
}
-bool WebRtcVoiceEngine::StartRtcEventLog(rtc::PlatformFile file) {
- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
- webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog();
- if (event_log) {
- return event_log->StartLogging(file);
- }
- LOG_RTCERR0(StartRtcEventLog);
- return false;
-}
-
-void WebRtcVoiceEngine::StopRtcEventLog() {
- RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
- webrtc::RtcEventLog* event_log = voe_wrapper_->codec()->GetEventLog();
- if (event_log) {
- event_log->StopLogging();
- return;
- }
- LOG_RTCERR0(StopRtcEventLog);
-}
-
int WebRtcVoiceEngine::CreateVoEChannel() {
RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
return voe_wrapper_->base()->CreateChannel(voe_config_);

Powered by Google App Engine
This is Rietveld 408576698