webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Processed review comments and rebased. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/call/call.cc ('K') | « webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc » ('j') | webrtc/pc/channelmanager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

index d469e675e41f78b2410d66322cbf107a8c9abf98..a5011f786cccd8d2f322f51ce06de2e0eedd0b88 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

@@ -25,7 +25,7 @@ namespace bwe {

RembBweSender::RembBweSender(int kbps, BitrateObserver* observer, Clock* clock)

: bitrate_controller_(

- BitrateController::CreateBitrateController(clock, observer)),

+ BitrateController::CreateBitrateController(clock, observer, nullptr)),

feedback_observer_(bitrate_controller_->CreateRtcpBandwidthObserver()),

clock_(clock) {

assert(kbps >= kMinBitrateKbps);