webrtc/call.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Processed review comments and rebased. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/call.h

diff --git a/webrtc/call.h b/webrtc/call.h

index 313c5e58c16f49446c8d6fbcdaa92950179628a8..323ddc53881a79a740f94fa4383ac16d66200e72 100644

--- a/webrtc/call.h

+++ b/webrtc/call.h

@@ -17,6 +17,7 @@

#include "webrtc/audio_receive_stream.h"

#include "webrtc/audio_send_stream.h"

#include "webrtc/audio_state.h"

+#include "webrtc/base/platform_file.h"

#include "webrtc/base/socket.h"

#include "webrtc/video_receive_stream.h"

#include "webrtc/video_send_stream.h"

@@ -137,6 +138,11 @@ class Call {

virtual void OnSentPacket(const rtc::SentPacket& sent_packet) = 0;

+ virtual bool StartEventLog(rtc::PlatformFile log_file,

+ int64_t max_size_bytes) = 0;

the sun 2016/03/23 10:26:45 nit: remove blank line

ivoc 2016/03/23 14:27:26 Done.

+ virtual void StopEventLog() = 0;

virtual ~Call() {}

};

« webrtc/api/peerconnectionproxy.h ('K') | « webrtc/audio/audio_send_stream_unittest.cc ('k') | webrtc/call/call.cc » ('j') | webrtc/call/call.cc » ('J')