Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Processed review comments and rebased. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 22109c4088e9415f0f55015ee95b9747dea24b4d..776093c817e15f2904bf79409d727980211a0ffd 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -457,6 +457,17 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
virtual IceConnectionState ice_connection_state() = 0;
virtual IceGatheringState ice_gathering_state() = 0;
+ // Starts RtcEventLog using existing file. Takes ownership of |file| and
+ // passes it on to Call, which will take the ownership. If the
+ // operation fails the file will be closed. The logging will stop
+ // automatically after 10 minutes have passed, or when the StopRtcEventLog
+ // function is called.
+ virtual bool StartRtcEventLog(rtc::PlatformFile file,
+ int64_t max_size_bytes) = 0;
+
+ // Stops logging the RtcEventLog.
+ virtual void StopRtcEventLog() = 0;
+
// Terminates all media and closes the transport.
virtual void Close() = 0;
@@ -610,20 +621,14 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
// Stops logging the AEC dump.
virtual void StopAecDump() = 0;
- // Starts RtcEventLog using existing file. Takes ownership of |file| and
- // passes it on to VoiceEngine, which will take the ownership. If the
- // operation fails the file will be closed. The logging will stop
- // automatically after 10 minutes have passed, or when the StopRtcEventLog
- // function is called.
- // This function as well as the StopRtcEventLog don't really belong on this
- // interface, this is a temporary solution until we move the logging object
- // from inside voice engine to webrtc::Call, which will happen when the VoE
- // restructuring effort is further along.
- // TODO(ivoc): Move this into being:
- // PeerConnection => MediaController => webrtc::Call.
+ // This function is deprecated and will be removed when Chrome is updated to
+ // use the equivalent function on PeerConnectionInterface.
+ // TODO(ivoc) Remove after Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
- // Stops logging the RtcEventLog.
+ // This function is deprecated and will be removed when Chrome is updated to
+ // use the equivalent function on PeerConnectionInterface.
+ // TODO(ivoc) Remove after Chrome is updated.
virtual void StopRtcEventLog() = 0;
protected:

Powered by Google App Engine
This is Rietveld 408576698