Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: webrtc/media/base/mediaengine.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Introduce proxy object for RtcEventLog and handle other comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 virtual const std::vector<VideoCodec>& video_codecs() = 0; 86 virtual const std::vector<VideoCodec>& video_codecs() = 0;
87 virtual RtpCapabilities GetVideoCapabilities() = 0; 87 virtual RtpCapabilities GetVideoCapabilities() = 0;
88 88
89 // Starts AEC dump using existing file, a maximum file size in bytes can be 89 // Starts AEC dump using existing file, a maximum file size in bytes can be
90 // specified. Logging is stopped just before the size limit is exceeded. 90 // specified. Logging is stopped just before the size limit is exceeded.
91 // If max_size_bytes is set to a value <= 0, no limit will be used. 91 // If max_size_bytes is set to a value <= 0, no limit will be used.
92 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0; 92 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
93 93
94 // Stops recording AEC dump. 94 // Stops recording AEC dump.
95 virtual void StopAecDump() = 0; 95 virtual void StopAecDump() = 0;
96
97 // Starts RtcEventLog using existing file.
98 virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
99
100 // Stops recording an RtcEventLog.
101 virtual void StopRtcEventLog() = 0;
102 }; 96 };
103 97
104 98
105 #if !defined(DISABLE_MEDIA_ENGINE_FACTORY) 99 #if !defined(DISABLE_MEDIA_ENGINE_FACTORY)
106 class MediaEngineFactory { 100 class MediaEngineFactory {
107 public: 101 public:
108 typedef cricket::MediaEngineInterface* (*MediaEngineCreateFunction)(); 102 typedef cricket::MediaEngineInterface* (*MediaEngineCreateFunction)();
109 // Creates a media engine, using either the compiled system default or the 103 // Creates a media engine, using either the compiled system default or the
110 // creation function specified in SetCreateFunction, if specified. 104 // creation function specified in SetCreateFunction, if specified.
111 static MediaEngineInterface* Create(); 105 static MediaEngineInterface* Create();
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 } 168 }
175 169
176 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) { 170 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
177 return voice_.StartAecDump(file, max_size_bytes); 171 return voice_.StartAecDump(file, max_size_bytes);
178 } 172 }
179 173
180 virtual void StopAecDump() { 174 virtual void StopAecDump() {
181 voice_.StopAecDump(); 175 voice_.StopAecDump();
182 } 176 }
183 177
184 virtual bool StartRtcEventLog(rtc::PlatformFile file) {
185 return voice_.StartRtcEventLog(file);
186 }
187
188 virtual void StopRtcEventLog() { voice_.StopRtcEventLog(); }
189
190 protected: 178 protected:
191 VOICE voice_; 179 VOICE voice_;
192 VIDEO video_; 180 VIDEO video_;
193 }; 181 };
194 182
195 enum DataChannelType { 183 enum DataChannelType {
196 DCT_NONE = 0, 184 DCT_NONE = 0,
197 DCT_RTP = 1, 185 DCT_RTP = 1,
198 DCT_SCTP = 2 186 DCT_SCTP = 2
199 }; 187 };
200 188
201 class DataEngineInterface { 189 class DataEngineInterface {
202 public: 190 public:
203 virtual ~DataEngineInterface() {} 191 virtual ~DataEngineInterface() {}
204 virtual DataMediaChannel* CreateChannel(DataChannelType type) = 0; 192 virtual DataMediaChannel* CreateChannel(DataChannelType type) = 0;
205 virtual const std::vector<DataCodec>& data_codecs() = 0; 193 virtual const std::vector<DataCodec>& data_codecs() = 0;
206 }; 194 };
207 195
208 } // namespace cricket 196 } // namespace cricket
209 197
210 #endif // WEBRTC_MEDIA_BASE_MEDIAENGINE_H_ 198 #endif // WEBRTC_MEDIA_BASE_MEDIAENGINE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698