Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/modules/congestion_controller/congestion_controller_unittest.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Another rebase and accompanying changes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "testing/gmock/include/gmock/gmock.h" 11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 #include "webrtc/call/mock/mock_rtc_event_log.h"
13 #include "webrtc/modules/pacing/mock/mock_paced_sender.h" 14 #include "webrtc/modules/pacing/mock/mock_paced_sender.h"
14 #include "webrtc/modules/congestion_controller/include/congestion_controller.h" 15 #include "webrtc/modules/congestion_controller/include/congestion_controller.h"
15 #include "webrtc/modules/congestion_controller/include/mock/mock_congestion_cont roller.h" 16 #include "webrtc/modules/congestion_controller/include/mock/mock_congestion_cont roller.h"
16 #include "webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitra te_observer.h" 17 #include "webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitra te_observer.h"
17 #include "webrtc/system_wrappers/include/clock.h" 18 #include "webrtc/system_wrappers/include/clock.h"
18 19
19 using testing::_; 20 using testing::_;
20 using testing::NiceMock; 21 using testing::NiceMock;
21 using testing::Return; 22 using testing::Return;
22 using testing::SaveArg; 23 using testing::SaveArg;
23 using testing::StrictMock; 24 using testing::StrictMock;
24 25
25 namespace webrtc { 26 namespace webrtc {
26 namespace test { 27 namespace test {
27 28
28 class CongestionControllerTest : public ::testing::Test { 29 class CongestionControllerTest : public ::testing::Test {
29 protected: 30 protected:
30 CongestionControllerTest() : clock_(123456) {} 31 CongestionControllerTest() : clock_(123456) {}
31 ~CongestionControllerTest() override {} 32 ~CongestionControllerTest() override {}
32 33
33 void SetUp() override { 34 void SetUp() override {
34 pacer_ = new NiceMock<MockPacedSender>(); 35 pacer_ = new NiceMock<MockPacedSender>();
35 std::unique_ptr<PacedSender> pacer(pacer_); // Passes ownership. 36 std::unique_ptr<PacedSender> pacer(pacer_); // Passes ownership.
36 std::unique_ptr<PacketRouter> packet_router(new PacketRouter()); 37 std::unique_ptr<PacketRouter> packet_router(new PacketRouter());
37 controller_.reset( 38 controller_.reset(new CongestionController(
38 new CongestionController(&clock_, &observer_, &remote_bitrate_observer_, 39 &clock_, &observer_, &remote_bitrate_observer_, &event_log_,
39 std::move(packet_router), std::move(pacer))); 40 std::move(packet_router), std::move(pacer)));
40 bandwidth_observer_.reset( 41 bandwidth_observer_.reset(
41 controller_->GetBitrateController()->CreateRtcpBandwidthObserver()); 42 controller_->GetBitrateController()->CreateRtcpBandwidthObserver());
42 43
43 // Set the initial bitrate estimate and expect the |observer| and |pacer_| 44 // Set the initial bitrate estimate and expect the |observer| and |pacer_|
44 // to be updated. 45 // to be updated.
45 EXPECT_CALL(observer_, OnNetworkChanged(kInitialBitrateBps, _, _)); 46 EXPECT_CALL(observer_, OnNetworkChanged(kInitialBitrateBps, _, _));
46 EXPECT_CALL(*pacer_, SetEstimatedBitrate(kInitialBitrateBps)); 47 EXPECT_CALL(*pacer_, SetEstimatedBitrate(kInitialBitrateBps));
47 controller_->SetBweBitrates(0, kInitialBitrateBps, 5 * kInitialBitrateBps); 48 controller_->SetBweBitrates(0, kInitialBitrateBps, 5 * kInitialBitrateBps);
48 } 49 }
49 50
50 SimulatedClock clock_; 51 SimulatedClock clock_;
51 StrictMock<MockCongestionObserver> observer_; 52 StrictMock<MockCongestionObserver> observer_;
52 NiceMock<MockPacedSender>* pacer_; 53 NiceMock<MockPacedSender>* pacer_;
53 NiceMock<MockRemoteBitrateObserver> remote_bitrate_observer_; 54 NiceMock<MockRemoteBitrateObserver> remote_bitrate_observer_;
55 MockRtcEventLog event_log_;
54 std::unique_ptr<RtcpBandwidthObserver> bandwidth_observer_; 56 std::unique_ptr<RtcpBandwidthObserver> bandwidth_observer_;
55 std::unique_ptr<CongestionController> controller_; 57 std::unique_ptr<CongestionController> controller_;
56 const uint32_t kInitialBitrateBps = 60000; 58 const uint32_t kInitialBitrateBps = 60000;
57 }; 59 };
58 60
59 TEST_F(CongestionControllerTest, OnNetworkChanged) { 61 TEST_F(CongestionControllerTest, OnNetworkChanged) {
60 // Test no change. 62 // Test no change.
61 clock_.AdvanceTimeMilliseconds(25); 63 clock_.AdvanceTimeMilliseconds(25);
62 controller_->Process(); 64 controller_->Process();
63 65
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 164
163 // Let the pacer not be full next time the controller checks. 165 // Let the pacer not be full next time the controller checks.
164 EXPECT_CALL(*pacer_, ExpectedQueueTimeMs()) 166 EXPECT_CALL(*pacer_, ExpectedQueueTimeMs())
165 .WillOnce(Return(PacedSender::kMaxQueueLengthMs - 1)); 167 .WillOnce(Return(PacedSender::kMaxQueueLengthMs - 1));
166 EXPECT_CALL(observer_, OnNetworkChanged(kInitialBitrateBps * 2, _, _)); 168 EXPECT_CALL(observer_, OnNetworkChanged(kInitialBitrateBps * 2, _, _));
167 controller_->Process(); 169 controller_->Process();
168 } 170 }
169 171
170 } // namespace test 172 } // namespace test
171 } // namespace webrtc 173 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698