Move RtcEventLog object from inside VoiceEngine to Call.

webrtc/modules/bitrate_controller/include/bitrate_controller.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  *  Usage: this class will register multiple RtcpBitrateObserver's one at each
  *  RTCP module. It will aggregate the results and run one bandwidth estimation
  *  and push the result to the encoders via BitrateObserver(s).
  */
 
 #ifndef WEBRTC_MODULES_BITRATE_CONTROLLER_INCLUDE_BITRATE_CONTROLLER_H_
 #define WEBRTC_MODULES_BITRATE_CONTROLLER_INCLUDE_BITRATE_CONTROLLER_H_
 
 #include <map>
 
+#include "webrtc/base/deprecation.h"
 #include "webrtc/modules/include/module.h"
 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
 
 namespace webrtc {
 
 class CriticalSectionWrapper;
 class RtcEventLog;
 struct PacketInfo;
 
 class BitrateObserver {
@@ skipping 11 matching lines @@
 };
 
 class BitrateController : public Module {
   // This class collects feedback from all streams sent to a peer (via
   // RTCPBandwidthObservers). It does one  aggregated send side bandwidth
   // estimation and divide the available bitrate between all its registered
   // BitrateObservers.
  public:
   static const int kDefaultStartBitrateKbps = 300;
 
+  // TODO(ivoc): Remove this function.
+  RTC_DEPRECATED static BitrateController* CreateBitrateController(
+      Clock* clock,
+      BitrateObserver* observer);
+
   static BitrateController* CreateBitrateController(Clock* clock,
-                                                    BitrateObserver* observer);
+                                                    BitrateObserver* observer,
+                                                    RtcEventLog* event_log);

[tommi, 2016/04/04 14:26:47]

is the ownership/lifetime of |observer| and |event_log| handled the same way?

[ivoc, 2016/04/05 08:02:58]

The |observer| is Call itself in this case, and |event_log| is a member of Call,
so they should have the same lifetime.
BitrateController is a member of CongestionController, which is also a member of
Call. So everything is part of the Call family :-)

[tommi, 2016/04/07 13:21:53]

I see.  Well, that does sound a bit fragile but OK for now.  As we do further
updates, we can improve on object ownership, lifetime and how to make those
things clear in the code.

   virtual ~BitrateController() {}
 
   virtual RtcpBandwidthObserver* CreateRtcpBandwidthObserver() = 0;
 
   virtual void SetStartBitrate(int start_bitrate_bps) = 0;
   virtual void SetMinMaxBitrate(int min_bitrate_bps, int max_bitrate_bps) = 0;
 
   virtual void UpdateDelayBasedEstimate(uint32_t bitrate_bps) = 0;
 
-  virtual void SetEventLog(RtcEventLog* event_log) = 0;
-
   // Gets the available payload bandwidth in bits per second. Note that
   // this bandwidth excludes packet headers.
   virtual bool AvailableBandwidth(uint32_t* bandwidth) const = 0;
 
   virtual void SetReservedBitrate(uint32_t reserved_bitrate_bps) = 0;
 };
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_BITRATE_CONTROLLER_INCLUDE_BITRATE_CONTROLLER_H_