Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: webrtc/pc/channelmanager.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Processed review comments and rebased. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // The operations below occur on the main thread. 118 // The operations below occur on the main thread.
119 119
120 // Starts AEC dump using existing file, with a specified maximum file size in 120 // Starts AEC dump using existing file, with a specified maximum file size in
121 // bytes. When the limit is reached, logging will stop and the file will be 121 // bytes. When the limit is reached, logging will stop and the file will be
122 // closed. If max_size_bytes is set to <= 0, no limit will be used. 122 // closed. If max_size_bytes is set to <= 0, no limit will be used.
123 bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes); 123 bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes);
124 124
125 // Stops recording AEC dump. 125 // Stops recording AEC dump.
126 void StopAecDump(); 126 void StopAecDump();
127 127
128 // Starts RtcEventLog using existing file. 128 sigslot::signal2<VideoCapturer*, CaptureState> SignalVideoCaptureStateChange;
the sun 2016/03/23 10:26:45 bad merge?
ivoc 2016/03/23 14:27:26 Oh, oops, I think this is from the common ancestor
129 bool StartRtcEventLog(rtc::PlatformFile file);
130
131 // Stops logging RtcEventLog.
132 void StopRtcEventLog();
133 129
134 private: 130 private:
135 typedef std::vector<VoiceChannel*> VoiceChannels; 131 typedef std::vector<VoiceChannel*> VoiceChannels;
136 typedef std::vector<VideoChannel*> VideoChannels; 132 typedef std::vector<VideoChannel*> VideoChannels;
137 typedef std::vector<DataChannel*> DataChannels; 133 typedef std::vector<DataChannel*> DataChannels;
138 134
139 void Construct(MediaEngineInterface* me, 135 void Construct(MediaEngineInterface* me,
140 DataEngineInterface* dme, 136 DataEngineInterface* dme,
141 rtc::Thread* worker_thread); 137 rtc::Thread* worker_thread);
142 bool InitMediaEngine_w(); 138 bool InitMediaEngine_w();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 170
175 int audio_output_volume_; 171 int audio_output_volume_;
176 bool enable_rtx_; 172 bool enable_rtx_;
177 173
178 bool capturing_; 174 bool capturing_;
179 }; 175 };
180 176
181 } // namespace cricket 177 } // namespace cricket
182 178
183 #endif // WEBRTC_PC_CHANNELMANAGER_H_ 179 #endif // WEBRTC_PC_CHANNELMANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698