webrtc/api/peerconnectionproxy.h - Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/api/peerconnectionproxy.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Processed review comments and rebased. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/api/peerconnectioninterface.h ('k') | webrtc/audio/audio_receive_stream.h » ('j') | webrtc/call.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 const PeerConnectionInterface::RTCConfiguration&);	67 const PeerConnectionInterface::RTCConfiguration&);

68 PROXY_METHOD1(bool, AddIceCandidate, const IceCandidateInterface*)	68 PROXY_METHOD1(bool, AddIceCandidate, const IceCandidateInterface*)

69 PROXY_METHOD1(bool,	69 PROXY_METHOD1(bool,

70 RemoveIceCandidates,	70 RemoveIceCandidates,

71 const std::vector<cricket::Candidate>&);	71 const std::vector<cricket::Candidate>&);

72 PROXY_METHOD1(void, RegisterUMAObserver, UMAObserver*)	72 PROXY_METHOD1(void, RegisterUMAObserver, UMAObserver*)

73 PROXY_METHOD0(SignalingState, signaling_state)	73 PROXY_METHOD0(SignalingState, signaling_state)

74 PROXY_METHOD0(IceState, ice_state)	74 PROXY_METHOD0(IceState, ice_state)

75 PROXY_METHOD0(IceConnectionState, ice_connection_state)	75 PROXY_METHOD0(IceConnectionState, ice_connection_state)

76 PROXY_METHOD0(IceGatheringState, ice_gathering_state)	76 PROXY_METHOD0(IceGatheringState, ice_gathering_state)

	77 PROXY_METHOD2(bool, StartRtcEventLog, rtc::PlatformFile, int64_t)
	the sun 2016/03/23 10:26:44 nit: add comments in peeroconnectionfactoryproxy.h nit: add comments in peeroconnectionfactoryproxy.h about removing the methods there. ivoc 2016/03/23 14:27:26 Done. Show quoted text On 2016/03/23 10:26:44, the sun wrote: > nit: add comments in peeroconnectionfactoryproxy.h about removing the methods > there. Done.
	78 PROXY_METHOD0(void, StopRtcEventLog)

77 PROXY_METHOD0(void, Close)	79 PROXY_METHOD0(void, Close)

78 END_PROXY()	80 END_PROXY()

79	81

80 } // namespace webrtc	82 } // namespace webrtc

81	83

82 #endif // WEBRTC_API_PEERCONNECTIONPROXY_H_	84 #endif // WEBRTC_API_PEERCONNECTIONPROXY_H_

OLD	NEW