Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: webrtc/call/rtc_event_log.h

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Undid unneccessary changes to rtp_rtcp module. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 virtual void SetBufferDuration(int64_t buffer_duration_us) = 0; 43 virtual void SetBufferDuration(int64_t buffer_duration_us) = 0;
44 44
45 // Starts logging for the specified duration to the specified file. 45 // Starts logging for the specified duration to the specified file.
46 // The logging will stop automatically after the specified duration. 46 // The logging will stop automatically after the specified duration.
47 // If the file already exists it will be overwritten. 47 // If the file already exists it will be overwritten.
48 // If the file cannot be opened, the RtcEventLog will not start logging. 48 // If the file cannot be opened, the RtcEventLog will not start logging.
49 virtual void StartLogging(const std::string& file_name, int duration_ms) = 0; 49 virtual void StartLogging(const std::string& file_name, int duration_ms) = 0;
50 50
51 // Starts logging until either the 10 minute timer runs out or the StopLogging 51 // Starts logging until either the 10 minute timer runs out or the StopLogging
52 // function is called. The RtcEventLog takes ownership of the supplied 52 // function is called. The RtcEventLog takes ownership of the supplied
53 // rtc::PlatformFile. 53 // rtc::PlatformFile. The max_size_bytes argument is ignored, it is added here
54 // for future use.
55 virtual bool StartLogging(rtc::PlatformFile log_file,
56 int64_t max_size_bytes) {
57 return StartLogging(log_file);
58 }
59
54 virtual bool StartLogging(rtc::PlatformFile log_file) = 0; 60 virtual bool StartLogging(rtc::PlatformFile log_file) = 0;
55 61
56 virtual void StopLogging() = 0; 62 virtual void StopLogging() = 0;
57 63
58 // Logs configuration information for webrtc::VideoReceiveStream 64 // Logs configuration information for webrtc::VideoReceiveStream
59 virtual void LogVideoReceiveStreamConfig( 65 virtual void LogVideoReceiveStreamConfig(
60 const webrtc::VideoReceiveStream::Config& config) = 0; 66 const webrtc::VideoReceiveStream::Config& config) = 0;
61 67
62 // Logs configuration information for webrtc::VideoSendStream 68 // Logs configuration information for webrtc::VideoSendStream
63 virtual void LogVideoSendStreamConfig( 69 virtual void LogVideoSendStreamConfig(
(...skipping 22 matching lines...) Expand all
86 92
87 // Reads an RtcEventLog file and returns true when reading was successful. 93 // Reads an RtcEventLog file and returns true when reading was successful.
88 // The result is stored in the given EventStream object. 94 // The result is stored in the given EventStream object.
89 static bool ParseRtcEventLog(const std::string& file_name, 95 static bool ParseRtcEventLog(const std::string& file_name,
90 rtclog::EventStream* result); 96 rtclog::EventStream* result);
91 }; 97 };
92 98
93 } // namespace webrtc 99 } // namespace webrtc
94 100
95 #endif // WEBRTC_CALL_RTC_EVENT_LOG_H_ 101 #endif // WEBRTC_CALL_RTC_EVENT_LOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698