Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: webrtc/call/call.cc

Issue 1748403002: Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Undid unneccessary changes to rtp_rtcp module. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 void SetBitrateConfig( 87 void SetBitrateConfig(
88 const webrtc::Call::Config::BitrateConfig& bitrate_config) override; 88 const webrtc::Call::Config::BitrateConfig& bitrate_config) override;
89 void SignalNetworkState(NetworkState state) override; 89 void SignalNetworkState(NetworkState state) override;
90 90
91 void OnSentPacket(const rtc::SentPacket& sent_packet) override; 91 void OnSentPacket(const rtc::SentPacket& sent_packet) override;
92 92
93 // Implements BitrateObserver. 93 // Implements BitrateObserver.
94 void OnNetworkChanged(uint32_t bitrate_bps, uint8_t fraction_loss, 94 void OnNetworkChanged(uint32_t bitrate_bps, uint8_t fraction_loss,
95 int64_t rtt_ms) override; 95 int64_t rtt_ms) override;
96 96
97 webrtc::RtcEventLog* RtcEventLog() override { return event_log_.get(); }
98
97 private: 99 private:
98 DeliveryStatus DeliverRtcp(MediaType media_type, const uint8_t* packet, 100 DeliveryStatus DeliverRtcp(MediaType media_type, const uint8_t* packet,
99 size_t length); 101 size_t length);
100 DeliveryStatus DeliverRtp(MediaType media_type, 102 DeliveryStatus DeliverRtp(MediaType media_type,
101 const uint8_t* packet, 103 const uint8_t* packet,
102 size_t length, 104 size_t length,
103 const PacketTime& packet_time); 105 const PacketTime& packet_time);
104 106
105 void ConfigureSync(const std::string& sync_group) 107 void ConfigureSync(const std::string& sync_group)
106 EXCLUSIVE_LOCKS_REQUIRED(receive_crit_); 108 EXCLUSIVE_LOCKS_REQUIRED(receive_crit_);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 GUARDED_BY(receive_crit_); 143 GUARDED_BY(receive_crit_);
142 144
143 rtc::scoped_ptr<RWLockWrapper> send_crit_; 145 rtc::scoped_ptr<RWLockWrapper> send_crit_;
144 // Audio and Video send streams are owned by the client that creates them. 146 // Audio and Video send streams are owned by the client that creates them.
145 std::map<uint32_t, AudioSendStream*> audio_send_ssrcs_ GUARDED_BY(send_crit_); 147 std::map<uint32_t, AudioSendStream*> audio_send_ssrcs_ GUARDED_BY(send_crit_);
146 std::map<uint32_t, VideoSendStream*> video_send_ssrcs_ GUARDED_BY(send_crit_); 148 std::map<uint32_t, VideoSendStream*> video_send_ssrcs_ GUARDED_BY(send_crit_);
147 std::set<VideoSendStream*> video_send_streams_ GUARDED_BY(send_crit_); 149 std::set<VideoSendStream*> video_send_streams_ GUARDED_BY(send_crit_);
148 150
149 VideoSendStream::RtpStateMap suspended_video_send_ssrcs_; 151 VideoSendStream::RtpStateMap suspended_video_send_ssrcs_;
150 152
151 RtcEventLog* event_log_ = nullptr; 153 rtc::scoped_ptr<webrtc::RtcEventLog> event_log_;
152 154
153 // The following members are only accessed (exclusively) from one thread and 155 // The following members are only accessed (exclusively) from one thread and
154 // from the destructor, and therefore doesn't need any explicit 156 // from the destructor, and therefore doesn't need any explicit
155 // synchronization. 157 // synchronization.
156 int64_t received_video_bytes_; 158 int64_t received_video_bytes_;
157 int64_t received_audio_bytes_; 159 int64_t received_audio_bytes_;
158 int64_t received_rtcp_bytes_; 160 int64_t received_rtcp_bytes_;
159 int64_t first_rtp_packet_received_ms_; 161 int64_t first_rtp_packet_received_ms_;
160 int64_t last_rtp_packet_received_ms_; 162 int64_t last_rtp_packet_received_ms_;
161 int64_t first_packet_sent_ms_; 163 int64_t first_packet_sent_ms_;
(...skipping 22 matching lines...) Expand all
184 : clock_(Clock::GetRealTimeClock()), 186 : clock_(Clock::GetRealTimeClock()),
185 num_cpu_cores_(CpuInfo::DetectNumberOfCores()), 187 num_cpu_cores_(CpuInfo::DetectNumberOfCores()),
186 module_process_thread_(ProcessThread::Create("ModuleProcessThread")), 188 module_process_thread_(ProcessThread::Create("ModuleProcessThread")),
187 pacer_thread_(ProcessThread::Create("PacerThread")), 189 pacer_thread_(ProcessThread::Create("PacerThread")),
188 call_stats_(new CallStats(clock_)), 190 call_stats_(new CallStats(clock_)),
189 bitrate_allocator_(new BitrateAllocator()), 191 bitrate_allocator_(new BitrateAllocator()),
190 config_(config), 192 config_(config),
191 network_enabled_(true), 193 network_enabled_(true),
192 receive_crit_(RWLockWrapper::CreateRWLock()), 194 receive_crit_(RWLockWrapper::CreateRWLock()),
193 send_crit_(RWLockWrapper::CreateRWLock()), 195 send_crit_(RWLockWrapper::CreateRWLock()),
196 event_log_(RtcEventLog::Create()),
194 received_video_bytes_(0), 197 received_video_bytes_(0),
195 received_audio_bytes_(0), 198 received_audio_bytes_(0),
196 received_rtcp_bytes_(0), 199 received_rtcp_bytes_(0),
197 first_rtp_packet_received_ms_(-1), 200 first_rtp_packet_received_ms_(-1),
198 last_rtp_packet_received_ms_(-1), 201 last_rtp_packet_received_ms_(-1),
199 first_packet_sent_ms_(-1), 202 first_packet_sent_ms_(-1),
200 estimated_send_bitrate_sum_kbits_(0), 203 estimated_send_bitrate_sum_kbits_(0),
201 pacer_bitrate_sum_kbits_(0), 204 pacer_bitrate_sum_kbits_(0),
202 num_bitrate_updates_(0), 205 num_bitrate_updates_(0),
203 remb_(clock_), 206 remb_(clock_),
204 congestion_controller_(new CongestionController(clock_, this, &remb_)) { 207 congestion_controller_(
208 new CongestionController(clock_, this, &remb_, event_log_.get())) {
205 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); 209 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
206 RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0); 210 RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0);
207 RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps, 211 RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps,
208 config.bitrate_config.min_bitrate_bps); 212 config.bitrate_config.min_bitrate_bps);
209 if (config.bitrate_config.max_bitrate_bps != -1) { 213 if (config.bitrate_config.max_bitrate_bps != -1) {
210 RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps, 214 RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps,
211 config.bitrate_config.start_bitrate_bps); 215 config.bitrate_config.start_bitrate_bps);
212 } 216 }
213 if (config.audio_state.get()) {
214 ScopedVoEInterface<VoECodec> voe_codec(voice_engine());
215 event_log_ = voe_codec->GetEventLog();
216 }
217 217
218 Trace::CreateTrace(); 218 Trace::CreateTrace();
219 call_stats_->RegisterStatsObserver(congestion_controller_.get()); 219 call_stats_->RegisterStatsObserver(congestion_controller_.get());
220 220
221 congestion_controller_->SetBweBitrates( 221 congestion_controller_->SetBweBitrates(
222 config_.bitrate_config.min_bitrate_bps, 222 config_.bitrate_config.min_bitrate_bps,
223 config_.bitrate_config.start_bitrate_bps, 223 config_.bitrate_config.start_bitrate_bps,
224 config_.bitrate_config.max_bitrate_bps); 224 config_.bitrate_config.max_bitrate_bps);
225 congestion_controller_->GetBitrateController()->SetEventLog(event_log_);
226 225
227 module_process_thread_->Start(); 226 module_process_thread_->Start();
228 module_process_thread_->RegisterModule(call_stats_.get()); 227 module_process_thread_->RegisterModule(call_stats_.get());
229 module_process_thread_->RegisterModule(congestion_controller_.get()); 228 module_process_thread_->RegisterModule(congestion_controller_.get());
230 pacer_thread_->RegisterModule(congestion_controller_->pacer()); 229 pacer_thread_->RegisterModule(congestion_controller_->pacer());
231 pacer_thread_->RegisterModule( 230 pacer_thread_->RegisterModule(
232 congestion_controller_->GetRemoteBitrateEstimator(true)); 231 congestion_controller_->GetRemoteBitrateEstimator(true));
233 pacer_thread_->Start(); 232 pacer_thread_->Start();
234 } 233 }
235 234
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 audio_send_stream->config().rtp.ssrc); 341 audio_send_stream->config().rtp.ssrc);
343 RTC_DCHECK(num_deleted == 1); 342 RTC_DCHECK(num_deleted == 1);
344 } 343 }
345 delete audio_send_stream; 344 delete audio_send_stream;
346 } 345 }
347 346
348 webrtc::AudioReceiveStream* Call::CreateAudioReceiveStream( 347 webrtc::AudioReceiveStream* Call::CreateAudioReceiveStream(
349 const webrtc::AudioReceiveStream::Config& config) { 348 const webrtc::AudioReceiveStream::Config& config) {
350 TRACE_EVENT0("webrtc", "Call::CreateAudioReceiveStream"); 349 TRACE_EVENT0("webrtc", "Call::CreateAudioReceiveStream");
351 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); 350 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
352 AudioReceiveStream* receive_stream = new AudioReceiveStream( 351 AudioReceiveStream* receive_stream =
353 congestion_controller_.get(), config, config_.audio_state); 352 new AudioReceiveStream(congestion_controller_.get(), config,
353 config_.audio_state, event_log_.get());
354 { 354 {
355 WriteLockScoped write_lock(*receive_crit_); 355 WriteLockScoped write_lock(*receive_crit_);
356 RTC_DCHECK(audio_receive_ssrcs_.find(config.rtp.remote_ssrc) == 356 RTC_DCHECK(audio_receive_ssrcs_.find(config.rtp.remote_ssrc) ==
357 audio_receive_ssrcs_.end()); 357 audio_receive_ssrcs_.end());
358 audio_receive_ssrcs_[config.rtp.remote_ssrc] = receive_stream; 358 audio_receive_ssrcs_[config.rtp.remote_ssrc] = receive_stream;
359 ConfigureSync(config.sync_group); 359 ConfigureSync(config.sync_group);
360 } 360 }
361 return receive_stream; 361 return receive_stream;
362 } 362 }
363 363
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 if (!network_enabled_) 400 if (!network_enabled_)
401 send_stream->SignalNetworkState(kNetworkDown); 401 send_stream->SignalNetworkState(kNetworkDown);
402 402
403 WriteLockScoped write_lock(*send_crit_); 403 WriteLockScoped write_lock(*send_crit_);
404 for (uint32_t ssrc : config.rtp.ssrcs) { 404 for (uint32_t ssrc : config.rtp.ssrcs) {
405 RTC_DCHECK(video_send_ssrcs_.find(ssrc) == video_send_ssrcs_.end()); 405 RTC_DCHECK(video_send_ssrcs_.find(ssrc) == video_send_ssrcs_.end());
406 video_send_ssrcs_[ssrc] = send_stream; 406 video_send_ssrcs_[ssrc] = send_stream;
407 } 407 }
408 video_send_streams_.insert(send_stream); 408 video_send_streams_.insert(send_stream);
409 409
410 if (event_log_) 410 event_log_->LogVideoSendStreamConfig(config);
411 event_log_->LogVideoSendStreamConfig(config);
412 411
413 return send_stream; 412 return send_stream;
414 } 413 }
415 414
416 void Call::DestroyVideoSendStream(webrtc::VideoSendStream* send_stream) { 415 void Call::DestroyVideoSendStream(webrtc::VideoSendStream* send_stream) {
417 TRACE_EVENT0("webrtc", "Call::DestroyVideoSendStream"); 416 TRACE_EVENT0("webrtc", "Call::DestroyVideoSendStream");
418 RTC_DCHECK(send_stream != nullptr); 417 RTC_DCHECK(send_stream != nullptr);
419 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); 418 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
420 419
421 send_stream->Stop(); 420 send_stream->Stop();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 config.rtp.rtx.begin(); 463 config.rtp.rtx.begin();
465 if (it != config.rtp.rtx.end()) 464 if (it != config.rtp.rtx.end())
466 video_receive_ssrcs_[it->second.ssrc] = receive_stream; 465 video_receive_ssrcs_[it->second.ssrc] = receive_stream;
467 video_receive_streams_.insert(receive_stream); 466 video_receive_streams_.insert(receive_stream);
468 467
469 ConfigureSync(config.sync_group); 468 ConfigureSync(config.sync_group);
470 469
471 if (!network_enabled_) 470 if (!network_enabled_)
472 receive_stream->SignalNetworkState(kNetworkDown); 471 receive_stream->SignalNetworkState(kNetworkDown);
473 472
474 if (event_log_) 473 event_log_->LogVideoReceiveStreamConfig(config);
475 event_log_->LogVideoReceiveStreamConfig(config);
476 474
477 return receive_stream; 475 return receive_stream;
478 } 476 }
479 477
480 void Call::DestroyVideoReceiveStream( 478 void Call::DestroyVideoReceiveStream(
481 webrtc::VideoReceiveStream* receive_stream) { 479 webrtc::VideoReceiveStream* receive_stream) {
482 TRACE_EVENT0("webrtc", "Call::DestroyVideoReceiveStream"); 480 TRACE_EVENT0("webrtc", "Call::DestroyVideoReceiveStream");
483 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); 481 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
484 RTC_DCHECK(receive_stream != nullptr); 482 RTC_DCHECK(receive_stream != nullptr);
485 VideoReceiveStream* receive_stream_impl = nullptr; 483 VideoReceiveStream* receive_stream_impl = nullptr;
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 // Do NOT broadcast! Also make sure it's a valid packet. 663 // Do NOT broadcast! Also make sure it's a valid packet.
666 // Return DELIVERY_UNKNOWN_SSRC if it can be determined that 664 // Return DELIVERY_UNKNOWN_SSRC if it can be determined that
667 // there's no receiver of the packet. 665 // there's no receiver of the packet.
668 received_rtcp_bytes_ += length; 666 received_rtcp_bytes_ += length;
669 bool rtcp_delivered = false; 667 bool rtcp_delivered = false;
670 if (media_type == MediaType::ANY || media_type == MediaType::VIDEO) { 668 if (media_type == MediaType::ANY || media_type == MediaType::VIDEO) {
671 ReadLockScoped read_lock(*receive_crit_); 669 ReadLockScoped read_lock(*receive_crit_);
672 for (VideoReceiveStream* stream : video_receive_streams_) { 670 for (VideoReceiveStream* stream : video_receive_streams_) {
673 if (stream->DeliverRtcp(packet, length)) { 671 if (stream->DeliverRtcp(packet, length)) {
674 rtcp_delivered = true; 672 rtcp_delivered = true;
675 if (event_log_) 673 event_log_->LogRtcpPacket(kIncomingPacket, media_type, packet, length);
676 event_log_->LogRtcpPacket(kIncomingPacket, media_type, packet,
677 length);
678 } 674 }
679 } 675 }
680 } 676 }
681 if (media_type == MediaType::ANY || media_type == MediaType::VIDEO) { 677 if (media_type == MediaType::ANY || media_type == MediaType::VIDEO) {
682 ReadLockScoped read_lock(*send_crit_); 678 ReadLockScoped read_lock(*send_crit_);
683 for (VideoSendStream* stream : video_send_streams_) { 679 for (VideoSendStream* stream : video_send_streams_) {
684 if (stream->DeliverRtcp(packet, length)) { 680 if (stream->DeliverRtcp(packet, length)) {
685 rtcp_delivered = true; 681 rtcp_delivered = true;
686 if (event_log_) 682 event_log_->LogRtcpPacket(kIncomingPacket, media_type, packet, length);
687 event_log_->LogRtcpPacket(kIncomingPacket, media_type, packet,
688 length);
689 } 683 }
690 } 684 }
691 } 685 }
692 return rtcp_delivered ? DELIVERY_OK : DELIVERY_PACKET_ERROR; 686 return rtcp_delivered ? DELIVERY_OK : DELIVERY_PACKET_ERROR;
693 } 687 }
694 688
695 PacketReceiver::DeliveryStatus Call::DeliverRtp(MediaType media_type, 689 PacketReceiver::DeliveryStatus Call::DeliverRtp(MediaType media_type,
696 const uint8_t* packet, 690 const uint8_t* packet,
697 size_t length, 691 size_t length,
698 const PacketTime& packet_time) { 692 const PacketTime& packet_time) {
699 TRACE_EVENT0("webrtc", "Call::DeliverRtp"); 693 TRACE_EVENT0("webrtc", "Call::DeliverRtp");
700 // Minimum RTP header size. 694 // Minimum RTP header size.
701 if (length < 12) 695 if (length < 12)
702 return DELIVERY_PACKET_ERROR; 696 return DELIVERY_PACKET_ERROR;
703 697
704 last_rtp_packet_received_ms_ = clock_->TimeInMilliseconds(); 698 last_rtp_packet_received_ms_ = clock_->TimeInMilliseconds();
705 if (first_rtp_packet_received_ms_ == -1) 699 if (first_rtp_packet_received_ms_ == -1)
706 first_rtp_packet_received_ms_ = last_rtp_packet_received_ms_; 700 first_rtp_packet_received_ms_ = last_rtp_packet_received_ms_;
707 701
708 uint32_t ssrc = ByteReader<uint32_t>::ReadBigEndian(&packet[8]); 702 uint32_t ssrc = ByteReader<uint32_t>::ReadBigEndian(&packet[8]);
709 ReadLockScoped read_lock(*receive_crit_); 703 ReadLockScoped read_lock(*receive_crit_);
710 if (media_type == MediaType::ANY || media_type == MediaType::AUDIO) { 704 if (media_type == MediaType::ANY || media_type == MediaType::AUDIO) {
711 auto it = audio_receive_ssrcs_.find(ssrc); 705 auto it = audio_receive_ssrcs_.find(ssrc);
712 if (it != audio_receive_ssrcs_.end()) { 706 if (it != audio_receive_ssrcs_.end()) {
713 received_audio_bytes_ += length; 707 received_audio_bytes_ += length;
714 auto status = it->second->DeliverRtp(packet, length, packet_time) 708 auto status = it->second->DeliverRtp(packet, length, packet_time)
715 ? DELIVERY_OK 709 ? DELIVERY_OK
716 : DELIVERY_PACKET_ERROR; 710 : DELIVERY_PACKET_ERROR;
717 if (status == DELIVERY_OK && event_log_) 711 if (status == DELIVERY_OK)
718 event_log_->LogRtpHeader(kIncomingPacket, media_type, packet, length); 712 event_log_->LogRtpHeader(kIncomingPacket, media_type, packet, length);
719 return status; 713 return status;
720 } 714 }
721 } 715 }
722 if (media_type == MediaType::ANY || media_type == MediaType::VIDEO) { 716 if (media_type == MediaType::ANY || media_type == MediaType::VIDEO) {
723 auto it = video_receive_ssrcs_.find(ssrc); 717 auto it = video_receive_ssrcs_.find(ssrc);
724 if (it != video_receive_ssrcs_.end()) { 718 if (it != video_receive_ssrcs_.end()) {
725 received_video_bytes_ += length; 719 received_video_bytes_ += length;
726 auto status = it->second->DeliverRtp(packet, length, packet_time) 720 auto status = it->second->DeliverRtp(packet, length, packet_time)
727 ? DELIVERY_OK 721 ? DELIVERY_OK
728 : DELIVERY_PACKET_ERROR; 722 : DELIVERY_PACKET_ERROR;
729 if (status == DELIVERY_OK && event_log_) 723 if (status == DELIVERY_OK)
730 event_log_->LogRtpHeader(kIncomingPacket, media_type, packet, length); 724 event_log_->LogRtpHeader(kIncomingPacket, media_type, packet, length);
731 return status; 725 return status;
732 } 726 }
733 } 727 }
734 return DELIVERY_UNKNOWN_SSRC; 728 return DELIVERY_UNKNOWN_SSRC;
735 } 729 }
736 730
737 PacketReceiver::DeliveryStatus Call::DeliverPacket( 731 PacketReceiver::DeliveryStatus Call::DeliverPacket(
738 MediaType media_type, 732 MediaType media_type,
739 const uint8_t* packet, 733 const uint8_t* packet,
740 size_t length, 734 size_t length,
741 const PacketTime& packet_time) { 735 const PacketTime& packet_time) {
742 // TODO(solenberg): Tests call this function on a network thread, libjingle 736 // TODO(solenberg): Tests call this function on a network thread, libjingle
743 // calls on the worker thread. We should move towards always using a network 737 // calls on the worker thread. We should move towards always using a network
744 // thread. Then this check can be enabled. 738 // thread. Then this check can be enabled.
745 // RTC_DCHECK(!configuration_thread_checker_.CalledOnValidThread()); 739 // RTC_DCHECK(!configuration_thread_checker_.CalledOnValidThread());
746 if (RtpHeaderParser::IsRtcp(packet, length)) 740 if (RtpHeaderParser::IsRtcp(packet, length))
747 return DeliverRtcp(media_type, packet, length); 741 return DeliverRtcp(media_type, packet, length);
748 742
749 return DeliverRtp(media_type, packet, length, packet_time); 743 return DeliverRtp(media_type, packet, length, packet_time);
750 } 744 }
751 745
752 } // namespace internal 746 } // namespace internal
753 } // namespace webrtc 747 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698