Move RtcEventLog object from inside VoiceEngine to Call.

webrtc/api/peerconnection.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 14 matching lines @@
 #include "webrtc/api/mediastreamproxy.h"
 #include "webrtc/api/mediastreamtrackproxy.h"
 #include "webrtc/api/remoteaudiosource.h"
 #include "webrtc/api/remotevideocapturer.h"
 #include "webrtc/api/rtpreceiver.h"
 #include "webrtc/api/rtpsender.h"
 #include "webrtc/api/streamcollection.h"
 #include "webrtc/api/videosource.h"
 #include "webrtc/api/videotrack.h"
 #include "webrtc/base/arraysize.h"
+#include "webrtc/base/bind.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
 #include "webrtc/base/trace_event.h"
+#include "webrtc/call.h"
+#include "webrtc/call/rtc_event_log.h"
 #include "webrtc/media/sctp/sctpdataengine.h"
 #include "webrtc/p2p/client/basicportallocator.h"
 #include "webrtc/pc/channelmanager.h"
 #include "webrtc/system_wrappers/include/field_trial.h"
 
 namespace {
 
 using webrtc::DataChannel;
 using webrtc::MediaConstraintsInterface;
 using webrtc::MediaStreamInterface;
@@ skipping 1170 matching lines @@
           kEnumCounterAddressFamily, kPeerConnection_IPv6,
           kPeerConnectionAddressFamilyCounter_Max);
     } else {
       uma_observer_->IncrementEnumCounter(
           kEnumCounterAddressFamily, kPeerConnection_IPv4,
           kPeerConnectionAddressFamilyCounter_Max);
     }
   }
 }
 
+bool PeerConnection::StartRtcEventLog(rtc::PlatformFile file,
+                                      int64_t max_size_bytes) {
+  return factory_->worker_thread()->Invoke<bool>(rtc::Bind(
+      &PeerConnection::StartRtcEventLog_w, this, file, max_size_bytes));
+}
+
+void PeerConnection::StopRtcEventLog() {
+  factory_->worker_thread()->Invoke<void>(
+      rtc::Bind(&PeerConnection::StopRtcEventLog_w, this));
+}
+
 const SessionDescriptionInterface* PeerConnection::local_description() const {
   return session_->local_description();
 }
 
 const SessionDescriptionInterface* PeerConnection::remote_description() const {
   return session_->remote_description();
 }
 
 void PeerConnection::Close() {
   TRACE_EVENT0("webrtc", "PeerConnection::Close");
@@ skipping 853 matching lines @@
 
 DataChannel* PeerConnection::FindDataChannelBySid(int sid) const {
   for (const auto& channel : sctp_data_channels_) {
     if (channel->id() == sid) {
       return channel;
     }
   }
   return nullptr;
 }
 
+bool PeerConnection::StartRtcEventLog_w(rtc::PlatformFile file,
+                                        int64_t max_size_bytes) {
+  RTC_DCHECK(factory_->worker_thread()->IsCurrent());
+  return media_controller_->call_w()->RtcEventLog()->StartLogging(

[the sun, 2016/03/21 13:03:08]

Is Call::RtcEventLog used anywhere but here?

If not, I think we should remove it and instead add a Start/Stop pair of
functions on Call. That will keep the API surface down and the RtcEventLog
interface remains internal business. Exposing the interface like you do right
now gives the client more than it bargained for, and effectively makes
RtcEventLog (which should really be named RtcEventLogInterface btw) an API
available for 3rd parties (assuming Call will be made available for 3rd
parties).

[terelius, 2016/03/21 20:47:46]

+1

[ivoc, 2016/03/22 13:44:54]

Good point, I changed it to a start/stop pair.

+      file, max_size_bytes);
+}
+
+void PeerConnection::StopRtcEventLog_w() {
+  RTC_DCHECK(factory_->worker_thread()->IsCurrent());
+  media_controller_->call_w()->RtcEventLog()->StopLogging();
+}
 }  // namespace webrtc