webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc - Issue 1746773002: [rtp_rtcp] tmmbr helper simplified by moving set_to_send member out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

Issue 1746773002: [rtp_rtcp] tmmbr helper simplified by moving set_to_send member out (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtcp_sender.h ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

index f440da489d817351f9c3b334a75a7b2ee9c5325b..047a27314adc5adb1d8c56b11d4ba01f4a5d3ffa 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

@@ -696,7 +696,7 @@ TEST_F(RtcpSenderTest, SendTmmbn) {

const uint32_t kPacketOh = 40;

const uint32_t kSourceSsrc = 12345;

bounding_set.AddEntry(kBitrateKbps, kPacketOh, kSourceSsrc);

- EXPECT_EQ(0, rtcp_sender_->SetTMMBN(&bounding_set));

+ rtcp_sender_->SetTMMBN(&bounding_set);

EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpSr));

EXPECT_EQ(1, parser()->sender_report()->num_packets());

EXPECT_EQ(1, parser()->tmmbn()->num_packets());

@@ -716,7 +716,7 @@ TEST_F(RtcpSenderTest, SendTmmbn) {

TEST_F(RtcpSenderTest, SendsTmmbnIfSetAndEmpty) {

rtcp_sender_->SetRTCPStatus(RtcpMode::kCompound);

TMMBRSet bounding_set;

- EXPECT_EQ(0, rtcp_sender_->SetTMMBN(&bounding_set));

+ rtcp_sender_->SetTMMBN(&bounding_set);

EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpSr));

EXPECT_EQ(1, parser()->sender_report()->num_packets());

EXPECT_EQ(1, parser()->tmmbn()->num_packets());