Modifies SDK and iOS detection for helper method that needs iOS 9+

Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=NONE
R=tkchin@webrtc.org

Committed: https://crrev.com/ab12c47160591ff78a92da304e143b84865d6d99
Cr-Commit-Position: refs/heads/master@{#11861}

[henrika_webrtc, 2016-02-29 13:48:55]

Description was changed from

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=
==========

to

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=
==========

[henrika_webrtc, 2016-02-29 13:48:55]

henrika@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[henrika_webrtc, 2016-02-29 13:49:26]

PTAL

[henrika_webrtc, 2016-02-29 13:50:38]

Description was changed from

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=
==========

to

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=NONE
==========

[tkchin_webrtc, 2016-03-01 21:51:34]

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
File webrtc/modules/utility/source/helpers_ios.mm (right):

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/helpers_ios.mm:27: ([[[UIDevice currentDevice]
systemVersion] \
can just use doubleValue to make these comparisons easier

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/helpers_ios.mm:197:
SYSTEM_VERSION_LESS_THAN(@"9.0.0") {
Wouldn't use macros. Instead have a bunch of functions you can call with cached
value.

e.g.
double GetSystemVersion() {
  static dispatch_once once_token;
  static double system_version;
  dispatch_once(&once_token, ^{
    system_version = [UIDevice currentDevice].systemVersion.doubleValue;
  });
  return system_version;
}

then e.g.:

bool isIos9OrGreater() {
  return GetSystemVersion() >= 9.0;
}

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/helpers_ios.mm:206: // TODO(henrika): can't use
iOS 9 APIs as the SDK version doesn't support
If it's unavailable we should just not use it. That means adding the
availability checks everywhere the function is used though.

[henrika_webrtc, 2016-03-02 14:49:50]

Thanks, PTAL

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
File webrtc/modules/utility/source/helpers_ios.mm (right):

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/helpers_ios.mm:27: ([[[UIDevice currentDevice]
systemVersion] \
Great idea, thanks!

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/helpers_ios.mm:197:
SYSTEM_VERSION_LESS_THAN(@"9.0.0") {
On 2016/03/01 21:51:33, tkchin_webrtc wrote:
> Wouldn't use macros. Instead have a bunch of functions you can call with
cached
> value.
> 
> e.g.
> double GetSystemVersion() {
>   static dispatch_once once_token;
>   static double system_version;
>   dispatch_once(&once_token, ^{
>     system_version = [UIDevice currentDevice].systemVersion.doubleValue;
>   });
>   return system_version;
> }
> 
> then e.g.:
> 
> bool isIos9OrGreater() {
>   return GetSystemVersion() >= 9.0;
> }

Done.

https://codereview.webrtc.org/1746023002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/helpers_ios.mm:206: // TODO(henrika): can't use
iOS 9 APIs as the SDK version doesn't support
On 2016/03/01 21:51:34, tkchin_webrtc wrote:
> If it's unavailable we should just not use it. That means adding the
> availability checks everywhere the function is used though.

Done.

[tkchin_webrtc, 2016-03-02 19:23:45]

lgtm

https://codereview.webrtc.org/1746023002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/1746023002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/audio_device_ios.mm:265: LOG(LS_INFO) << "
system version 1(2): " << ios::GetSystemVersionAsString();
do we need both?

[henrika_webrtc, 2016-03-03 13:55:16]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2016-03-03 13:55:25]

https://codereview.webrtc.org/1746023002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/1746023002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/audio_device_ios.mm:265: LOG(LS_INFO) << "
system version 1(2): " << ios::GetSystemVersionAsString();
If you don't mind I think we should keep both. Today we have:

[2823] (audio_device_ios.mm:265):  system version 1(2): 9.2.1
[2823] (audio_device_ios.mm:266):  system version 2(2): 9.2

hence, the x.x.1 is missing for the double representation. Ping me if you
disagree. I will land as is.

[commit-bot: I haz the power, 2016-03-03 13:55:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746023002/20001

[commit-bot: I haz the power, 2016-03-03 15:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 15:56:24]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[henrika_webrtc, 2016-03-03 16:00:04]

Description was changed from

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=NONE
==========

to

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=NONE
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ab12c47160591ff78a92da304...
==========

[henrika_webrtc, 2016-03-03 16:00:06]

Committed patchset #2 (id:20001) manually as
ab12c47160591ff78a92da304e143b84865d6d99 (presubmit successful).

[commit-bot: I haz the power, 2016-03-03 16:00:06]

Description was changed from

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=NONE
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ab12c47160591ff78a92da304...
==========

to

==========
Modifies SDK and iOS detection for helper method that needs iOS 9+

BUG=NONE
R=tkchin@webrtc.org

Committed: https://crrev.com/ab12c47160591ff78a92da304e143b84865d6d99
Cr-Commit-Position: refs/heads/master@{#11861}
==========

[commit-bot: I haz the power, 2016-03-03 16:00:09]

Patchset 2 (id:??) landed as
https://crrev.com/ab12c47160591ff78a92da304e143b84865d6d99
Cr-Commit-Position: refs/heads/master@{#11861}