Added an operator[] to Buffer, to make reading data easier.

Added an operator[] to Buffer, to make reading data easier.

Committed: https://crrev.com/b9338ac62b9a8a64568a62ad9ae4f2f7c3f732ca
Cr-Commit-Position: refs/heads/master@{#11819}

[ossu, 2016-02-29 12:18:59]

ossu@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, tommi@webrtc.org

[ossu, 2016-02-29 12:19:57]

By popular request: a small addition to Buffer. :)

[kwiberg-webrtc, 2016-02-29 12:40:46]

lgtm, but see comment

https://codereview.webrtc.org/1745033002/diff/1/webrtc/base/buffer.h
File webrtc/base/buffer.h (right):

https://codereview.webrtc.org/1745033002/diff/1/webrtc/base/buffer.h#newcode128
webrtc/base/buffer.h:128: uint8_t  operator[](size_t index) const { return
data()[index]; }
It's probably a good idea to DCHECK that the index is good; aside from brevity,
that's what makes operator[] worth having.

[ossu, 2016-02-29 12:48:53]

DCHECK it is!

https://codereview.webrtc.org/1745033002/diff/1/webrtc/base/buffer.h
File webrtc/base/buffer.h (right):

https://codereview.webrtc.org/1745033002/diff/1/webrtc/base/buffer.h#newcode128
webrtc/base/buffer.h:128: uint8_t  operator[](size_t index) const { return
data()[index]; }
On 2016/02/29 12:40:46, kwiberg-webrtc wrote:
> It's probably a good idea to DCHECK that the index is good; aside from
brevity,
> that's what makes operator[] worth having.

Acknowledged.

[tommi, 2016-02-29 13:10:07]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-02-29 13:10:08]

lgtm

[tommi, 2016-02-29 13:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1745033002/#ps20001 (title:
"Added DCHECKs for index against size_")

[commit-bot: I haz the power, 2016-02-29 13:10:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745033002/20001

[commit-bot: I haz the power, 2016-02-29 13:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 13:42:09]

Try jobs failed on following builders:
  linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[ossu, 2016-02-29 16:03:11]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2016-02-29 16:03:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745033002/20001

[commit-bot: I haz the power, 2016-02-29 17:36:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-29 17:36:51]

Description was changed from

==========
Added an operator[] to Buffer, to make reading data easier.
==========

to

==========
Added an operator[] to Buffer, to make reading data easier.

Committed: https://crrev.com/b9338ac62b9a8a64568a62ad9ae4f2f7c3f732ca
Cr-Commit-Position: refs/heads/master@{#11819}
==========

[commit-bot: I haz the power, 2016-02-29 17:36:51]

Patchset 2 (id:??) landed as
https://crrev.com/b9338ac62b9a8a64568a62ad9ae4f2f7c3f732ca
Cr-Commit-Position: refs/heads/master@{#11819}