Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1745003002: Move suspend_below_min_bitrate from VideoOptions to MediaConfig. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 4098 matching lines...) Expand 10 before | Expand all | Expand 10 after
4109 TransportInfo* audio = sdp->GetTransportInfoByName("audio"); 4109 TransportInfo* audio = sdp->GetTransportInfoByName("audio");
4110 ASSERT_TRUE(audio != NULL); 4110 ASSERT_TRUE(audio != NULL);
4111 ASSERT_TRUE(audio->description.identity_fingerprint.get() == NULL); 4111 ASSERT_TRUE(audio->description.identity_fingerprint.get() == NULL);
4112 audio->description.identity_fingerprint.reset( 4112 audio->description.identity_fingerprint.reset(
4113 rtc::SSLFingerprint::CreateFromRfc4572( 4113 rtc::SSLFingerprint::CreateFromRfc4572(
4114 rtc::DIGEST_SHA_256, kFakeDtlsFingerprint)); 4114 rtc::DIGEST_SHA_256, kFakeDtlsFingerprint));
4115 SetRemoteDescriptionOfferExpectError(kSdpWithoutSdesCrypto, 4115 SetRemoteDescriptionOfferExpectError(kSdpWithoutSdesCrypto,
4116 offer); 4116 offer);
4117 } 4117 }
4118 4118
4119 TEST_F(WebRtcSessionTest, TestSuspendBelowMinBitrateConstraint) {
4120 constraints_.reset(new FakeConstraints());
4121 constraints_->AddOptional(
4122 webrtc::MediaConstraintsInterface::kEnableVideoSuspendBelowMinBitrate,
4123 true);
4124 Init();
4125 SendAudioVideoStream1();
4126 SessionDescriptionInterface* offer = CreateOffer();
4127
4128 SetLocalDescriptionWithoutError(offer);
4129
4130 video_channel_ = media_engine_->GetVideoChannel(0);
4131
4132 ASSERT_TRUE(video_channel_ != NULL);
4133 const cricket::VideoOptions& video_options = video_channel_->options();
4134 EXPECT_EQ(rtc::Optional<bool>(true), video_options.suspend_below_min_bitrate);
4135 }
4136
4137 TEST_F(WebRtcSessionTest, TestCombinedAudioVideoBweConstraint) { 4119 TEST_F(WebRtcSessionTest, TestCombinedAudioVideoBweConstraint) {
4138 constraints_.reset(new FakeConstraints()); 4120 constraints_.reset(new FakeConstraints());
4139 constraints_->AddOptional( 4121 constraints_->AddOptional(
4140 webrtc::MediaConstraintsInterface::kCombinedAudioVideoBwe, 4122 webrtc::MediaConstraintsInterface::kCombinedAudioVideoBwe,
4141 true); 4123 true);
4142 Init(); 4124 Init();
4143 SendAudioVideoStream1(); 4125 SendAudioVideoStream1();
4144 SessionDescriptionInterface* offer = CreateOffer(); 4126 SessionDescriptionInterface* offer = CreateOffer();
4145 4127
4146 SetLocalDescriptionWithoutError(offer); 4128 SetLocalDescriptionWithoutError(offer);
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
4331 } 4313 }
4332 4314
4333 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test 4315 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test
4334 // currently fails because upon disconnection and reconnection OnIceComplete is 4316 // currently fails because upon disconnection and reconnection OnIceComplete is
4335 // called more than once without returning to IceGatheringGathering. 4317 // called more than once without returning to IceGatheringGathering.
4336 4318
4337 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests, 4319 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
4338 WebRtcSessionTest, 4320 WebRtcSessionTest,
4339 testing::Values(ALREADY_GENERATED, 4321 testing::Values(ALREADY_GENERATED,
4340 DTLS_IDENTITY_STORE)); 4322 DTLS_IDENTITY_STORE));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698