Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and landed as patchset #2 …

Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/fb45d170c08742058523f0cfe12b3f54638f61ad
Cr-Commit-Position: refs/heads/master@{#11809}

[perkj_webrtc, 2016-02-29 08:48:06]

Description was changed from

==========
Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and
landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation
since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426

This reverts commit 74622e061320d9fab4388c260b2d806de4b34e2f.
==========

to

==========
Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and
landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation
since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
TBR=pthatcher@webrtc.org
==========

[perkj_webrtc, 2016-02-29 08:49:14]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-02-29 08:49:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744153002/20001

[commit-bot: I haz the power, 2016-02-29 09:21:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 09:21:07]

Exceeded global retry quota

[commit-bot: I haz the power, 2016-02-29 11:07:49]

Description was changed from

==========
Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and
landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation
since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
TBR=pthatcher@webrtc.org
==========

to

==========
Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and
landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation
since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/fb45d170c08742058523f0cfe12b3f54638f61ad
Cr-Commit-Position: refs/heads/master@{#11809}
==========

[perkj_webrtc, 2016-02-29 11:07:50]

Description was changed from

==========
Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and
landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation
since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/fb45d170c08742058523f0cfe12b3f54638f61ad
Cr-Commit-Position: refs/heads/master@{#11809}
==========

to

==========
Reland Remove unused cricket::VideoCapturer methods. Originally reviewed and
landed as patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/)

I readded virtual bool Pause(bool paused) for now with a dummy implementation
since Chrome remoting override this method.

Original cl description:

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
bool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
TBR=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fb45d170c08742058523f0cfe...
==========

[commit-bot: I haz the power, 2016-02-29 11:07:50]

Patchset 2 (id:??) landed as
https://crrev.com/fb45d170c08742058523f0cfe12b3f54638f61ad
Cr-Commit-Position: refs/heads/master@{#11809}

[perkj_webrtc, 2016-02-29 11:07:52]

Committed patchset #2 (id:20001) manually as
fb45d170c08742058523f0cfe12b3f54638f61ad (presubmit successful).