Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1744123002: GN: Update audio_sink.h location (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
the sun, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Update audio_sink.h location This should have been a part of https://codereview.webrtc.org/1740873003/ but wasn't discovered since we cannot have --check turned on for GN yet. BUG=webrtc:5589 TBR=solenberg@webrtc.org, henrika@webrtc.org, Committed: https://chromium.googlesource.com/external/webrtc/+/50772f1e165b49fb59ceb85f0d6391dc64eda39f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50772f1e165b49fb59ceb85f0d6391dc64eda39f Cr-Commit-Position: refs/heads/master@{#11803}
4 years, 9 months ago (2016-02-29 05:50:00 UTC) #4
kjellander_webrtc
4 years, 9 months ago (2016-02-29 05:50:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50772f1e165b49fb59ceb85f0d6391dc64eda39f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698