Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1743613002: Revert of Cleanup of webrtc::VideoFrame. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, the sun, andresp, pbos-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Cleanup of webrtc::VideoFrame. (patchset #6 id:100001 of https://codereview.webrtc.org/1679323002/ ) Reason for revert: Breaks downstream compilation. Please make non-breaking API changes for the reland or coordinate fixing downstream code quickly with the sheriff. Original issue's description: > Cleanup of webrtc::VideoFrame. > > Delete EqualsFrame method, used only by tests. Delete one of the > CreateFrame methods. Drop return value for CreateEmptyFrame, CreateFrame > and CopyFrame. > > BUG=webrtc:5426 > > Committed: https://crrev.com/208019637bfed975f8f13b16d40b90e200763cd6 > Cr-Commit-Position: refs/heads/master@{#11783} TBR=pbos@webrtc.org,perkj@webrtc.org,pthatcher@webrtc.org,mflodman@webrtc.org,marpan@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/54ebfca9346f0881a7ef2c8511e7c851ca81942d Cr-Commit-Position: refs/heads/master@{#11789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -224 lines) Patch
M webrtc/common_video/common_video_unittests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 9 chunks +28 lines, -27 lines 0 comments Download
M webrtc/common_video/include/incoming_video_stream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 5 chunks +20 lines, -22 lines 0 comments Download
M webrtc/common_video/libyuv/scaler_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 6 chunks +78 lines, -30 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideocapturemodule.h View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M webrtc/modules/video_processing/test/denoiser_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/video_render/video_render_internal_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
D webrtc/test/frame_utils.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/test/frame_utils.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/test/webrtc_test_common.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/video_capture_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_frame.h View 2 chunks +35 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
Created Revert of Cleanup of webrtc::VideoFrame.
4 years, 10 months ago (2016-02-26 15:38:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743613002/1
4 years, 10 months ago (2016-02-26 15:38:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 15:38:58 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 15:39:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54ebfca9346f0881a7ef2c8511e7c851ca81942d
Cr-Commit-Position: refs/heads/master@{#11789}

Powered by Google App Engine
This is Rietveld 408576698