Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1743223002: Reland "Calculating ERLE in AEC more properly." (Closed)

Created:
4 years, 9 months ago by minyue-webrtc
Modified:
4 years, 9 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Calculating ERLE in AEC more properly." The original CL (https://codereview.webrtc.org/1644133002/) had an error in the unittest and did not get landed. This CL is to reland it, BUG= Committed: https://crrev.com/7b19b08c18ac9b797d2ef4477c96270c5a87af17 Cr-Commit-Position: refs/heads/master@{#11844}

Patch Set 1 #

Patch Set 2 : fixing the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 3 chunks +4 lines, -14 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
minyue-webrtc
Hi Per, You just reviewed this CL, but my bad that I did a mistake ...
4 years, 9 months ago (2016-02-29 14:59:33 UTC) #3
minyue-webrtc
Hi, a kindly ping for review
4 years, 9 months ago (2016-03-02 09:02:36 UTC) #4
peah-webrtc
On 2016/03/02 09:02:36, minyue-webrtc wrote: > Hi, a kindly ping for review lgtm
4 years, 9 months ago (2016-03-02 13:55:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743223002/20001
4 years, 9 months ago (2016-03-02 13:58:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 14:56:55 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:57:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b19b08c18ac9b797d2ef4477c96270c5a87af17
Cr-Commit-Position: refs/heads/master@{#11844}

Powered by Google App Engine
This is Rietveld 408576698