webrtc/modules/video_coding/timing.h - Issue 1742323002: VCMCodecTimer: Change filter from max to 95th percentile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/timing.h

Issue 1742323002: VCMCodecTimer: Change filter from max to 95th percentile (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rename 'max decode time' to 'required decode time' Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/percentile_filter.cc ('K') | « webrtc/modules/video_coding/percentile_filter_unittest.cc ('k') | webrtc/modules/video_coding/timing.cc » ('j') | webrtc/modules/video_coding/timing.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/timing.h

diff --git a/webrtc/modules/video_coding/timing.h b/webrtc/modules/video_coding/timing.h

index a4d0cf45433b34f7b8c3b6bfd62e271fd551986a..f61ebff595d24c6453c125dd1327ba9c2fe72c2a 100644

--- a/webrtc/modules/video_coding/timing.h

+++ b/webrtc/modules/video_coding/timing.h

@@ -94,7 +94,7 @@ class VCMTiming {

enum { kDelayMaxChangeMsPerS = 100 };

protected:

- int32_t MaxDecodeTimeMs(FrameType frame_type = kVideoFrameDelta) const

+ int64_t RequiredDecodeTimeMs() const

EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);

int64_t RenderTimeMsInternal(uint32_t frame_timestamp, int64_t now_ms) const

EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);